Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/ssh/apache_karaf_command_execution.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method do_login has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_login(user, pass, ip)
    opts = ssh_client_defaults.merge({
      :auth_methods    => ['password'],
      :port            => rport,
      :password        => pass,
Severity: Minor
Found in modules/auxiliary/scanner/ssh/apache_karaf_command_execution.rb - About 1 hr to fix

    Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => "Apache Karaf Default Credentials Command Execution",
      'Description'    => %q{
        This module exploits a default misconfiguration flaw on Apache Karaf versions 2.x-4.x.
    Severity: Minor
    Found in modules/auxiliary/scanner/ssh/apache_karaf_command_execution.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/auxiliary/scanner/ssh/apache_karaf_command_execution.rb - About 30 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            register_options(
      [
        Opt::RPORT(8101),
        OptString.new('USERNAME', [true, 'Username', 'karaf']),
        OptString.new('PASSWORD', [true, 'Password', 'karaf']),
        Severity: Minor
        Found in modules/auxiliary/scanner/ssh/apache_karaf_command_execution.rb and 3 other locations - About 20 mins to fix
        modules/auxiliary/scanner/http/epmp1000_get_chart_cmd_exec.rb on lines 31..37
        modules/auxiliary/scanner/http/epmp1000_ping_cmd_exec.rb on lines 31..37
        modules/exploits/linux/http/tiki_calendar_exec.rb on lines 49..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status