rapid7/metasploit-framework

View on GitHub
modules/auxiliary/scanner/vxworks/urgent11_check.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run_detections has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_detections(ip, port)
    print_status("#{ip}:#{port} being checked")

    final_ipnet_score        = 0
    final_vxworks_score      = 0
Severity: Major
Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 2 hrs to fix

    Method tcp_dos_detection has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def tcp_dos_detection(sock, ip, port)
        pkt = PacketFu::TCPPacket.new(config: @config)
    
        # IP destination address
        pkt.ip_daddr = ip
    Severity: Minor
    Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 1 hr to fix

      Method initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
          super(update_info(info,
            'Name'           => 'URGENT/11 Scanner, Based on Detection Tool by Armis',
            'Description'    => %q{
              This module detects VxWorks and the IPnet IP stack, along with devices
      Severity: Minor
      Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 1 hr to fix

        Method tcp_malformed_options_detection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def tcp_malformed_options_detection(sock, ip, port)
            pkt = PacketFu::TCPPacket.new(config: @config)
        
            # IP destination address
            pkt.ip_daddr = ip
        Severity: Minor
        Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 1 hr to fix

          Method run_detections has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def run_detections(ip, port)
              print_status("#{ip}:#{port} being checked")
          
              final_ipnet_score        = 0
              final_vxworks_score      = 0
          Severity: Minor
          Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method tcp_dos_detection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def tcp_dos_detection(sock, ip, port)
              pkt = PacketFu::TCPPacket.new(config: @config)
          
              # IP destination address
              pkt.ip_daddr = ip
          Severity: Minor
          Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method tcp_malformed_options_detection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def tcp_malformed_options_detection(sock, ip, port)
              pkt = PacketFu::TCPPacket.new(config: @config)
          
              # IP destination address
              pkt.ip_daddr = ip
          Severity: Minor
          Found in modules/auxiliary/scanner/vxworks/urgent11_check.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status