Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/server/capture/drda.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method on_client_data has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def on_client_data(c)
    data = c.get_once

    return if not data
Severity: Minor
Found in modules/auxiliary/server/capture/drda.rb - About 1 hr to fix

    Method on_client_data has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def on_client_data(c)
    data = c.get_once

    return if not data
    Severity: Minor
    Found in modules/auxiliary/server/capture/drda.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 32 locations. Consider refactoring.
    Open

      def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
    Severity: Major
    Found in modules/auxiliary/server/capture/drda.rb and 31 other locations - About 1 hr to fix
    modules/auxiliary/admin/misc/sercomm_dump_config.rb on lines 88..111
    modules/auxiliary/admin/scada/advantech_webaccess_dbvisitor_sqli.rb on lines 191..214
    modules/auxiliary/gather/apache_rave_creds.rb on lines 107..130
    modules/auxiliary/gather/d20pass.rb on lines 182..205
    modules/auxiliary/gather/doliwamp_traversal_creds.rb on lines 152..175
    modules/auxiliary/gather/hp_snac_domain_creds.rb on lines 90..113
    modules/auxiliary/gather/windows_deployment_services_shares.rb on lines 196..219
    modules/auxiliary/scanner/couchdb/couchdb_login.rb on lines 76..99
    modules/auxiliary/scanner/dcerpc/windows_deployment_services.rb on lines 214..237
    modules/auxiliary/scanner/http/openmind_messageos_login.rb on lines 72..95
    modules/auxiliary/scanner/http/radware_appdirector_enum.rb on lines 78..101
    modules/auxiliary/scanner/misc/dvr_config_disclosure.rb on lines 147..170
    modules/auxiliary/scanner/misc/dvr_config_disclosure.rb on lines 210..233
    modules/auxiliary/scanner/misc/raysharp_dvr_passwords.rb on lines 36..59
    modules/auxiliary/scanner/misc/rosewill_rxs3211_passwords.rb on lines 84..107
    modules/auxiliary/scanner/openvas/openvas_gsad_login.rb on lines 115..138
    modules/auxiliary/scanner/oracle/isqlplus_login.rb on lines 231..254
    modules/auxiliary/scanner/postgres/postgres_version.rb on lines 51..74
    modules/auxiliary/scanner/rservices/rsh_login.rb on lines 222..245
    modules/auxiliary/scanner/sap/sap_ctc_verb_tampering_user_mgmt.rb on lines 86..109
    modules/auxiliary/scanner/sap/sap_mgmt_con_brute_login.rb on lines 63..86
    modules/auxiliary/scanner/sap/sap_soap_bapi_user_create1.rb on lines 52..75
    modules/auxiliary/scanner/scada/koyo_login.rb on lines 127..150
    modules/auxiliary/server/capture/ftp.rb on lines 51..74
    modules/auxiliary/server/capture/http.rb on lines 107..130
    modules/auxiliary/server/capture/http_basic.rb on lines 57..80
    modules/auxiliary/server/capture/mysql.rb on lines 127..150
    modules/auxiliary/server/capture/pop3.rb on lines 53..76
    modules/auxiliary/server/capture/postgresql.rb on lines 41..64
    modules/auxiliary/server/capture/sip.rb on lines 105..128
    modules/exploits/linux/http/dlink_dir850l_unauth_exec.rb on lines 69..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def drda_ascii_to_ebdic(str)
    a2e = [
      "00010203372D2E2F1605250B0C0D0E0F101112133C3D322618193F271C1D1E1F" +
      "405A7F7B5B6C507D4D5D5C4E6B604B61F0F1F2F3F4F5F6F7F8F97A5E4C7E6E6F" +
      "7CC1C2C3C4C5C6C7C8C9D1D2D3D4D5D6D7D8D9E2E3E4E5E6E7E8E9ADE0BD5F6D" +
    Severity: Minor
    Found in modules/auxiliary/server/capture/drda.rb and 1 other location - About 35 mins to fix
    modules/auxiliary/server/capture/drda.rb on lines 87..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def drda_ebdic_to_ascii(str)
    e2a = [
      "000102039C09867F978D8E0B0C0D0E0F101112139D8508871819928F1C1D1E1F" +
      "80818283840A171B88898A8B8C050607909116939495960498999A9B14159E1A" +
      "20A0A1A2A3A4A5A6A7A8D52E3C282B7C26A9AAABACADAEAFB0B121242A293B5E" +
    Severity: Minor
    Found in modules/auxiliary/server/capture/drda.rb and 1 other location - About 35 mins to fix
    modules/auxiliary/server/capture/drda.rb on lines 72..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def initialize
    super(
      'Name'           => 'Authentication Capture: DRDA (DB2, Informix, Derby)',
      'Description'    => %q{
        This module provides a fake DRDA (DB2, Informix, Derby) server
    Severity: Minor
    Found in modules/auxiliary/server/capture/drda.rb and 1 other location - About 30 mins to fix
    modules/auxiliary/server/capture/postgresql.rb on lines 10..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          print_good("DRDA LOGIN #{@state[c][:name]} Database: #{@state[c][:database]}; #{@state[c][:user]} / #{@state[c][:pass]}")
    Severity: Minor
    Found in modules/auxiliary/server/capture/drda.rb and 1 other location - About 25 mins to fix
    modules/auxiliary/server/capture/postgresql.rb on lines 107..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @state[c] = {
      :name     => "#{c.peerhost}:#{c.peerport}",
      :ip       => c.peerhost,
      :port     => c.peerport,
      :user     => nil,
    Severity: Minor
    Found in modules/auxiliary/server/capture/drda.rb and 1 other location - About 15 mins to fix
    modules/auxiliary/server/capture/vnc.rb on lines 48..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status