Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/server/capture/http_javascript_keylogger.rb

Summary

Maintainability
C
1 day
Test Coverage

Method on_request_uri has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def on_request_uri(cli, request)

    cid = nil

    if request['Cookie'].to_s =~ /,?\s*id=([a-f0-9]{4,32})/i
Severity: Minor
Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_keylogger_js has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate_keylogger_js(base_url, cid)

    targ = Rex::Text.rand_text_alpha(12)

    code = <<EOS
Severity: Minor
Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 1 hr to fix

    Method on_request_uri has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def on_request_uri(cli, request)

    cid = nil

    if request['Cookie'].to_s =~ /,?\s*id=([a-f0-9]{4,32})/i
    Severity: Minor
    Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 1 hr to fix

      Method process_data has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def process_data(cli, request, cid, data)

    lines = [""]
    real  = ""
      Severity: Minor
      Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 1 hr to fix

        Method generate_base_url has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def generate_base_url(cli, req)
    port = nil
    host = Rex::Socket.source_address(cli.peerhost)

    if req['Host']
        Severity: Minor
        Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method process_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def process_data(cli, request, cid, data)

    lines = [""]
    real  = ""
        Severity: Minor
        Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate_demo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def generate_demo(base_url, cid)
    # This is the Demo Form Page <HTML>
    html = <<EOS
<html>
<head>
        Severity: Minor
        Found in modules/auxiliary/server/capture/http_javascript_keylogger.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status