Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/server/openssl_heartbeat_client_memory.rb

Summary

Maintainability
F
3 days
Test Coverage

Method process_openssl_cleartext_request has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  def process_openssl_cleartext_request(c, data)
    message_type, message_version, protocol_version = data.unpack("Cn@9n")

    if message_type == 0x15 and data.length >= 7
      message_level, message_reason = data[5,2].unpack("CC")
Severity: Minor
Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File openssl_heartbeat_client_memory.rb has 397 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::TcpServer
  include Msf::Auxiliary::Report

  def initialize
Severity: Minor
Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 5 hrs to fix

    Class MetasploitModule has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::TcpServer
  include Msf::Auxiliary::Report

  def initialize
    Severity: Minor
    Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 2 hrs to fix

      Method process_openssl_cleartext_request has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def process_openssl_cleartext_request(c, data)
    message_type, message_version, protocol_version = data.unpack("Cn@9n")

    if message_type == 0x15 and data.length >= 7
      message_level, message_reason = data[5,2].unpack("CC")
      Severity: Major
      Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 2 hrs to fix

        Method process_request has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def process_request(c)

    # Make this slightly harder to DoS
    if @state[c][:buff].to_s.length > (1024*128)
      print_status("#{@state[c][:name]} Buffer limit reached, dropping connection")
        Severity: Minor
        Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize
    super(
      'Name'           => 'OpenSSL Heartbeat (Heartbleed) Client Memory Exposure',
      'Description'    => %q{
        This module provides a fake SSL service that is intended to
        Severity: Minor
        Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 1 hr to fix

          Method generate_certificate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def generate_certificate
    key  = @cert_key
    cert = OpenSSL::X509::Certificate.new
    cert.version = 2
    cert.serial  = rand(0xFFFFFFFF)
          Severity: Minor
          Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 1 hr to fix

            Method tls1_calculate_crypto_keys has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def tls1_calculate_crypto_keys(c)
    @state[c][:master] = tls1_calculate_master_key(c)
    return unless @state[c][:master]

    key_block = tls1_prf(
            Severity: Minor
            Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 1 hr to fix

              Method openssl_send_server_hello has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def openssl_send_server_hello(c, hello, version)

    # If encrypted, use the TLS_RSA_WITH_AES_128_CBC_SHA; otherwise, use the
    # first cipher suite sent by the client.
    if @state[c][:encrypted]
              Severity: Minor
              Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 1 hr to fix

                Method store_captured_heartbeats has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def store_captured_heartbeats(c)
    if @state[c][:heartbeats].length > 0
      begin
        path = store_loot(
          "openssl.heartbleed.client",
                Severity: Minor
                Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 1 hr to fix

                  Method process_openssl_encrypted_request has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def process_openssl_encrypted_request(c, data)
    message_type, message_version, protocol_version = data.unpack("Cn@9n")

    return if @state[c][:shutdown]
    return unless data.length > 5
                  Severity: Minor
                  Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 1 hr to fix

                    Method process_openssl_encrypted_request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def process_openssl_encrypted_request(c, data)
    message_type, message_version, protocol_version = data.unpack("Cn@9n")

    return if @state[c][:shutdown]
    return unless data.length > 5
                    Severity: Minor
                    Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return
                    Severity: Major
                    Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if @state[c][:heartbeats].length >= heartbeat_limit
      print_status("#{@state[c][:name]} Encrypted heartbeats received [#{@state[c][:heartbeats].length} bytes total]")
      store_captured_heartbeats(c)
      c.close()
                      Severity: Minor
                      Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb and 1 other location - About 25 mins to fix
                      modules/auxiliary/server/openssl_heartbeat_client_memory.rb on lines 211..214

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 31.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            if @state[c][:heartbeats].length >= heartbeat_limit
        print_status("#{@state[c][:name]} Heartbeats received [#{@state[c][:heartbeats].length} bytes total]")
        store_captured_heartbeats(c)
        c.close()
                      Severity: Minor
                      Found in modules/auxiliary/server/openssl_heartbeat_client_memory.rb and 1 other location - About 25 mins to fix
                      modules/auxiliary/server/openssl_heartbeat_client_memory.rb on lines 252..255

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 31.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status