Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/sqli/dlink/dlink_central_wifimanager_sqli.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method run has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    unless check == Exploit::CheckCode::Vulnerable
      print_error 'Target does not seem to be vulnerable'
      return
    end
Severity: Minor
Found in modules/auxiliary/sqli/dlink/dlink_central_wifimanager_sqli.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'D-Link Central WiFiManager SQL injection',
Severity: Minor
Found in modules/auxiliary/sqli/dlink/dlink_central_wifimanager_sqli.rb - About 1 hr to fix

    Method dump_data has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def dump_data(sqli)
    print_good "DBMS version: #{sqli.version}"
    table_names = sqli.enum_table_names
    print_status 'Enumerating tables'
    table_names.each do |table_name|
    Severity: Minor
    Found in modules/auxiliary/sqli/dlink/dlink_central_wifimanager_sqli.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    check_error = nil
    sqli = create_sqli(dbms: PostgreSQLi::Common, opts: { encoder: :base64 }) do |payload|
      res = vulnerable_request(payload)
      if res && res.code == 200
      Severity: Minor
      Found in modules/auxiliary/sqli/dlink/dlink_central_wifimanager_sqli.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status