Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/voip/cisco_cucdm_call_forward.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method forward_calls has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def forward_calls
    # for a specific FINTNUMBER redirection
    uri = normalize_uri(target_uri.to_s)
    forward_to = datastore["FORWARDTO"]
    mac = datastore["MAC"]
Severity: Minor
Found in modules/auxiliary/voip/cisco_cucdm_call_forward.rb - About 1 hr to fix

    Method get_info has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_info
    uri = normalize_uri(target_uri.to_s)
    mac = datastore["MAC"]

    print_status("Getting fintnumbers and display names of the IP phone")
    Severity: Minor
    Found in modules/auxiliary/voip/cisco_cucdm_call_forward.rb - About 1 hr to fix

      Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info={})
    super(update_info(info,
      'Name'        => 'Viproy CUCDM IP Phone XML Services - Call Forwarding Tool',
      'Description' => %q{
        The BVSMWeb portal in the web framework in Cisco Unified Communications Domain Manager
      Severity: Minor
      Found in modules/auxiliary/voip/cisco_cucdm_call_forward.rb - About 1 hr to fix

        Method forward_calls has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def forward_calls
    # for a specific FINTNUMBER redirection
    uri = normalize_uri(target_uri.to_s)
    forward_to = datastore["FORWARDTO"]
    mac = datastore["MAC"]
        Severity: Minor
        Found in modules/auxiliary/voip/cisco_cucdm_call_forward.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status