Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/android/browser/samsung_knox_smdm_url.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method exploit_js has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit_js
    payload_id = rand_word

    js_obfuscate %Q|
Severity: Minor
Found in modules/exploits/android/browser/samsung_knox_smdm_url.rb - About 1 hr to fix

    Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'                => 'Samsung Galaxy KNOX Android Browser RCE',
      'Description'         => %q{
        A vulnerability exists in the KNOX security component of the Samsung Galaxy
    Severity: Minor
    Found in modules/exploits/android/browser/samsung_knox_smdm_url.rb - About 1 hr to fix

      Method on_request_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, req)
    if req.uri =~ /\/([a-zA-Z0-9]+)\.apk\/latest$/
      if req.method.upcase == 'HEAD'
        print_status "Serving metadata..."
        send_response(cli, '', magic_headers)
      Severity: Minor
      Found in modules/exploits/android/browser/samsung_knox_smdm_url.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status