Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/apple_ios/browser/safari_jit.rb

Summary

Maintainability
C
1 day
Test Coverage

File safari_jit.rb has 493 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = GoodRanking

  include Msf::Post::File
  include Msf::Exploit::Remote::HttpServer::HTML
Severity: Minor
Found in modules/exploits/apple_ios/browser/safari_jit.rb - About 7 hrs to fix

    Method initialize has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Safari Webkit JIT Exploit for iOS 7.1.2',
    Severity: Minor
    Found in modules/exploits/apple_ios/browser/safari_jit.rb - About 1 hr to fix

      Method on_request_uri has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)
    if datastore['DEBUG_EXPLOIT'] && request.uri =~ %r{/print$*}
      print_status("[*] #{request.body}")
      send_response(cli, '')
      return
      Severity: Minor
      Found in modules/exploits/apple_ios/browser/safari_jit.rb - About 1 hr to fix

        Method on_request_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def on_request_uri(cli, request)
    if datastore['DEBUG_EXPLOIT'] && request.uri =~ %r{/print$*}
      print_status("[*] #{request.body}")
      send_response(cli, '')
      return
        Severity: Minor
        Found in modules/exploits/apple_ios/browser/safari_jit.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status