Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/apple_ios/browser/webkit_createthis.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method on_request_uri has 867 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def on_request_uri(cli, request)
    if request.uri =~ %r{/apple-touch-icon*}
      return
    elsif request.uri =~ %r{/favicon*}
      return
Severity: Major
Found in modules/exploits/apple_ios/browser/webkit_createthis.rb - About 4 days to fix

    File webkit_createthis.rb has 934 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking

  include Msf::Post::File
  include Msf::Exploit::EXE
    Severity: Major
    Found in modules/exploits/apple_ios/browser/webkit_createthis.rb - About 2 days to fix

      Method on_request_uri has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)
    if request.uri =~ %r{/apple-touch-icon*}
      return
    elsif request.uri =~ %r{/favicon*}
      return
      Severity: Minor
      Found in modules/exploits/apple_ios/browser/webkit_createthis.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Safari Webkit Proxy Object Type Confusion',
      'Description'    => %q{
          This module exploits a type confusion bug in the Javascript Proxy object in
      Severity: Minor
      Found in modules/exploits/apple_ios/browser/webkit_createthis.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in modules/exploits/apple_ios/browser/webkit_createthis.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status