Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb

Summary

Maintainability
F
5 days
Test Coverage

File apache_superset_cookie_sig_rce.rb has 525 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = GoodRanking
  include Msf::Exploit::Remote::HttpClient

  def initialize(info = {})
Severity: Major
Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 1 day to fix

    Method mount_internal_database has 121 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def mount_internal_database
    # use cve-2023-39265 bypass to mount superset's internal sqlite db
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'api', 'v1', 'database/'),
      'method' => 'POST',
    Severity: Major
    Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 4 hrs to fix

      Method rce_implant has 113 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def rce_implant
    # create new dashboard
    vprint_status('Creating new dashboard')
    res = send_request_cgi(
      'keep_cookies' => true,
      Severity: Major
      Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 4 hrs to fix

        Method cleanup has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

          def cleanup
    super

    # We didn't know the previous values, so just blank out XXX
    unless (@client_id.nil? || @csrf_token.nil? || @db_id.nil? || @values_to_reset.nil?)
        Severity: Minor
        Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cleanup has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def cleanup
    super

    # We didn't know the previous values, so just blank out XXX
    unless (@client_id.nil? || @csrf_token.nil? || @db_id.nil? || @values_to_reset.nil?)
        Severity: Major
        Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 3 hrs to fix

          Method initialize has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Apache Superset Signed Cookie RCE',
          Severity: Major
          Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 2 hrs to fix

            Method rce_implant has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def rce_implant
    # create new dashboard
    vprint_status('Creating new dashboard')
    res = send_request_cgi(
      'keep_cookies' => true,
            Severity: Minor
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method mount_internal_database has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              def mount_internal_database
    # use cve-2023-39265 bypass to mount superset's internal sqlite db
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'api', 'v1', 'database/'),
      'method' => 'POST',
            Severity: Minor
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def check
    res = send_request_cgi!({
      'uri' => normalize_uri(target_uri.path, 'login/')
    })
    return Exploit::CheckCode::Unknown("#{peer} - Could not connect to web service - no response") if res.nil?
            Severity: Minor
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def check
    res = send_request_cgi!({
      'uri' => normalize_uri(target_uri.path, 'login/')
    })
    return Exploit::CheckCode::Unknown("#{peer} - Could not connect to web service - no response") if res.nil?
            Severity: Major
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 2 hrs to fix
            modules/auxiliary/gather/apache_superset_cookie_sig_priv_esc.rb on lines 60..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def validate_cookie(decoded_cookie, secret_key)
    print_status("#{peer} - Attempting to resign with key: #{secret_key}")
    encoded_cookie = Msf::Exploit::Remote::HTTP::FlaskUnsign::Session.sign(decoded_cookie, secret_key)

    print_status("#{peer} - New signed cookie: #{encoded_cookie}")
            Severity: Major
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 2 hrs to fix
            modules/auxiliary/gather/apache_superset_cookie_sig_priv_esc.rb on lines 96..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def get_secret_key(cookie)
    File.open(datastore['SECRET_KEYS_FILE'], 'rb').each do |secret|
      secret = secret.strip
      vprint_status("#{peer} - Checking secret key: #{secret}")
            Severity: Major
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 1 hr to fix
            modules/auxiliary/gather/apache_superset_cookie_sig_priv_esc.rb on lines 79..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'superset', 'sql_json/'),
      'method' => 'POST',
      'cookie' => "session=#{@admin_cookie};",
      'keep_cookies' => true,
            Severity: Major
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 1 hr to fix
            modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 419..444

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'superset', 'sql_json/'),
      'method' => 'POST',
      'cookie' => "session=#{@admin_cookie};",
      'keep_cookies' => true,
            Severity: Major
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 1 hr to fix
            modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 315..340

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                unless @dashboard_id.nil?
      print_status('Deleting dashboard')
      send_request_cgi(
        'keep_cookies' => true,
        'cookie' => "session=#{@admin_cookie};",
            Severity: Minor
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 25 mins to fix
            modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 615..626

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 31.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                unless @db_id.nil?
      print_status('Deleting database mapping')
      send_request_cgi(
        'keep_cookies' => true,
        'cookie' => "session=#{@admin_cookie};",
            Severity: Minor
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 1 other location - About 25 mins to fix
            modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 585..596

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 31.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 22 locations. Consider refactoring.
            Open

                      ['URL', 'https://github.com/Paradoxis/Flask-Unsign'],
          ['URL', 'https://vulcan.io/blog/cve-2023-27524-in-apache-superset-what-you-need-to-know/'],
          ['URL', 'https://www.horizon3.ai/cve-2023-27524-insecure-default-configuration-in-apache-superset-leads-to-remote-code-execution/'],
          ['URL', 'https://www.horizon3.ai/apache-superset-part-ii-rce-credential-harvesting-and-more/'],
          ['URL', 'https://github.com/horizon3ai/CVE-2023-27524/blob/main/CVE-2023-27524.py'],
            Severity: Major
            Found in modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb and 21 other locations - About 20 mins to fix
            modules/auxiliary/dos/http/hashcollision_dos.rb on lines 36..44
            modules/auxiliary/scanner/http/wp_woocommerce_payments_add_user.rb on lines 61..69
            modules/exploits/android/browser/webview_addjavascriptinterface.rb on lines 58..66
            modules/exploits/freebsd/local/rtld_execl_priv_esc.rb on lines 57..65
            modules/exploits/linux/http/zimbra_cpio_cve_2022_41352.rb on lines 44..52
            modules/exploits/linux/local/bpf_priv_esc.rb on lines 48..56
            modules/exploits/linux/local/cve_2021_3490_ebpf_alu32_bounds_check_lpe.rb on lines 53..61
            modules/exploits/linux/local/glibc_realpath_priv_esc.rb on lines 48..56
            modules/exploits/linux/local/systemtap_modprobe_options_priv_esc.rb on lines 43..51
            modules/exploits/linux/misc/cisco_ios_xe_rce.rb on lines 52..65
            modules/exploits/linux/misc/lprng_format_string.rb on lines 26..34
            modules/exploits/linux/upnp/dlink_upnp_msearch_exec.rb on lines 70..78
            modules/exploits/multi/browser/java_jre17_exec.rb on lines 43..51
            modules/exploits/multi/http/git_client_command_exec.rb on lines 47..55
            modules/exploits/multi/http/vtiger_soap_upload.rb on lines 33..41
            modules/exploits/windows/browser/ms13_022_silverlight_script_object.rb on lines 40..48
            modules/exploits/windows/browser/webex_ucf_newobject.rb on lines 40..48
            modules/exploits/windows/fileformat/allplayer_m3u_bof.rb on lines 31..39
            modules/exploits/windows/http/exchange_chainedserializationbinder_rce.rb on lines 45..54
            modules/exploits/windows/http/exchange_ecp_dlp_policy.rb on lines 49..57
            modules/exploits/windows/http/netgear_nms_rce.rb on lines 32..40

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status