Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/bitbucket_git_cmd_injection.rb

Summary

Maintainability
D
2 days
Test Coverage

Method check has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    res = send_request_cgi(
      'method' => 'GET',
      'keep_cookies' => true,
      'uri' => normalize_uri(target_uri.path, 'login')
Severity: Minor
Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Bitbucket Git Command Injection',
Severity: Major
Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 2 hrs to fix

    Method find_public_repo has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def find_public_repo
    print_status('Searching Bitbucket for publicly accessible repository')
    res = send_request_cgi(
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'rest/api/latest/repos'),
    Severity: Minor
    Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    res = send_request_cgi(
      'method' => 'GET',
      'keep_cookies' => true,
      'uri' => normalize_uri(target_uri.path, 'login')
    Severity: Minor
    Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 1 hr to fix

      Method authenticate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def authenticate
    print_status("Attempting to authenticate with user '#{username}' and password '#{password}'")
    res = send_request_cgi(
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'login'),
      Severity: Minor
      Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 1 hr to fix

        Method find_public_repo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def find_public_repo
    print_status('Searching Bitbucket for publicly accessible repository')
    res = send_request_cgi(
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'rest/api/latest/repos'),
        Severity: Minor
        Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 1 hr to fix

          Method authenticate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def authenticate
    print_status("Attempting to authenticate with user '#{username}' and password '#{password}'")
    res = send_request_cgi(
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'login'),
          Severity: Minor
          Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return CheckCode::Appears if revision.to_i < 10
          Severity: Major
          Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return CheckCode::NotVulnerable if num_vers <= Rex::Version.new('6.10.17')
            Severity: Major
            Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return CheckCode::Appears if revision.to_i < 4
              Severity: Major
              Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return CheckCode::Appears if revision.to_i < 3
                Severity: Major
                Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return CheckCode::Appears if revision.to_i < 17
                  Severity: Major
                  Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return CheckCode::Detected('Version unknown') unless matches && matches.length > 1
                    Severity: Major
                    Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return CheckCode::Appears if revision.to_i < 2
                      Severity: Major
                      Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return CheckCode::Appears if revision.to_i < 1
                        Severity: Major
                        Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return CheckCode::Appears
                          Severity: Major
                          Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb - About 30 mins to fix

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                register_options(
      [
        Opt::RPORT(7990),
        OptString.new('TARGETURI', [ true, 'The base URI of Bitbucket application', '/']),
        OptString.new('USERNAME', [ false, 'The username to authenticate with', '' ]),
                            Severity: Minor
                            Found in modules/exploits/linux/http/bitbucket_git_cmd_injection.rb and 4 other locations - About 15 mins to fix
                            modules/auxiliary/admin/http/nuuo_nvrmini_reset.rb on lines 38..44
                            modules/auxiliary/scanner/http/syncovery_linux_login.rb on lines 38..44
                            modules/auxiliary/scanner/http/wowza_streaming_engine_manager_login.rb on lines 35..41
                            modules/exploits/windows/http/advantech_iview_networkservlet_cmd_inject.rb on lines 72..78

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 26.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status