Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb

Summary

Maintainability
D
2 days
Test Coverage

Method brute_force_ids has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

  def brute_force_ids
    # perform a sanity check first
    if @host_id
      host_ids = [@host_id]
    else
Severity: Minor
Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Cacti 1.2.22 unauthenticated command injection',
Severity: Major
Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 3 hrs to fix

    Method brute_force_ids has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def brute_force_ids
    # perform a sanity check first
    if @host_id
      host_ids = [@host_id]
    else
    Severity: Major
    Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 2 hrs to fix

      File cacti_unauthenticated_cmd_injection.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::CmdStager
      Severity: Minor
      Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 2 hrs to fix

        Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    @host_id = datastore['HOST_ID'] if datastore['HOST_ID'].present?
    @local_data_id = datastore['LOCAL_DATA_ID'] if datastore['LOCAL_DATA_ID'].present?

    unless @host_id && @local_data_id
        Severity: Minor
        Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    # sanity check to see if the target is likely Cacti
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)
        Severity: Minor
        Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return CheckCode::Safe("The target is Cacti version #{version}")
        Severity: Major
        Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Unknown("Failed to obtain a valid Cacti version: #{e}")
          Severity: Major
          Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return [h_id, ld_id]
            Severity: Major
            Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return nil if potential_targets.empty?
              Severity: Major
              Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return nil
                Severity: Major
                Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      register_options([
      OptString.new('TARGETURI', [true, 'The base path to Cacti', '/']),
      OptString.new('X_FORWARDED_FOR_IP', [true, 'The IP to use in the X-Forwarded-For HTTP header. This should be resolvable to a hostname in the poller table.', '127.0.0.1']),
      OptInt.new('HOST_ID', [false, 'The host_id value to use. By default, the module will try to bruteforce this.']),
      OptInt.new('LOCAL_DATA_ID', [false, 'The local_data_id value to use. By default, the module will try to bruteforce this.'])
                  Severity: Minor
                  Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb and 1 other location - About 20 mins to fix
                  modules/exploits/unix/webapp/moinmoin_twikidraw.rb on lines 58..64

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 28.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if @host_id
      host_ids = [@host_id]
    else
      if datastore['MAX_HOST_ID'] < datastore['MIN_HOST_ID']
        fail_with(Failure::BadConfig, 'The value for MAX_HOST_ID is lower than MIN_HOST_ID. This is impossible')
                  Severity: Minor
                  Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb and 1 other location - About 20 mins to fix
                  modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb on lines 174..180

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 27.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if @local_data_id
      local_data_ids = [@local_data_ids]
    else
      if datastore['MAX_LOCAL_DATA_ID'] < datastore['MIN_LOCAL_DATA_ID']
        fail_with(Failure::BadConfig, 'The value for MAX_LOCAL_DATA_ID is lower than MIN_LOCAL_DATA_ID. This is impossible')
                  Severity: Minor
                  Found in modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb and 1 other location - About 20 mins to fix
                  modules/exploits/linux/http/cacti_unauthenticated_cmd_injection.rb on lines 165..171

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 27.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status