Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/cisco_rv32x_rce.rb

Summary

Maintainability
C
1 day
Test Coverage

Method primer has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def primer
    payload_url = get_uri
    print_status("Downloading configuration from #{peer}")
    if(datastore['USE_SSL'])
      print_status("Using SSL connection to router.")
Severity: Major
Found in modules/exploits/linux/http/cisco_rv32x_rce.rb - About 3 hrs to fix

    Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => "Cisco RV320 and RV325 Unauthenticated Remote Code Execution",
      'Description'    => %q{
        This exploit module combines an information disclosure (CVE-2019-1653)
    Severity: Minor
    Found in modules/exploits/linux/http/cisco_rv32x_rce.rb - About 2 hrs to fix

      Method primer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def primer
    payload_url = get_uri
    print_status("Downloading configuration from #{peer}")
    if(datastore['USE_SSL'])
      print_status("Using SSL connection to router.")
      Severity: Minor
      Found in modules/exploits/linux/http/cisco_rv32x_rce.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return nil
      Severity: Major
      Found in modules/exploits/linux/http/cisco_rv32x_rce.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return nil
        Severity: Major
        Found in modules/exploits/linux/http/cisco_rv32x_rce.rb - About 30 mins to fix

          Method check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    #Check if device is vulnerable by downloading the config
    res = send_request_cgi({'uri'=>normalize_uri("cgi-bin","config.exp")})

    unless res
          Severity: Minor
          Found in modules/exploits/linux/http/cisco_rv32x_rce.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  'vars_post' => {
          'page' => 'self_generator.htm',
                    'totalRules' => '1',
                    'OpenVPNRules' => '30',
                    'submitStatus' => '1',
          Severity: Minor
          Found in modules/exploits/linux/http/cisco_rv32x_rce.rb and 2 other locations - About 35 mins to fix
          modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb on lines 162..179
          plugins/session_notifier.rb on lines 22..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status