Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Craft CMS unauthenticated Remote Code Execution (RCE)',
Severity: Major
Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 3 hrs to fix

    Method check_phpinfo has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_phpinfo
    # checks vulnerability running phpinfo() and returns upload_tmp_dir and DOCUMENT_ROOT
    @config = { 'upload_tmp_dir' => nil, 'document_root' => nil }

    res = send_request_cgi({
    Severity: Minor
    Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method upload_webshell has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def upload_webshell
    # randomize file name if option WEBSHELL is not set
    if datastore['WEBSHELL'].blank?
      @webshell_name = "#{Rex::Text.rand_text_alpha(8..16)}.php"
    else
    Severity: Minor
    Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 1 hr to fix

      Method check_phpinfo has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check_phpinfo
    # checks vulnerability running phpinfo() and returns upload_tmp_dir and DOCUMENT_ROOT
    @config = { 'upload_tmp_dir' => nil, 'document_root' => nil }

    res = send_request_cgi({
      Severity: Minor
      Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 1 hr to fix

        Method on_new_session has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def on_new_session(session)
    # cleanup webshell in DOCUMENT_ROOT
    register_files_for_cleanup("#{@config['document_root']}/#{@webshell_name}")

    # Imagick plugin generates a php<random chars> file with MSL code in the directory set by
        Severity: Minor
        Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    # check if upload_tmp_dir and document_root is already initialized with AutoCheck set otherwise run check_phpinfo
    check_phpinfo unless datastore['AutoCheck']
    fail_with(Failure::NotVulnerable, 'Could not get required phpinfo. System is likely patched.') if @config['upload_tmp_dir'].nil? || @config['document_root'].nil?
    fail_with(Failure::UnexpectedReply, "Webshell #{@webshell_name} upload failed.") unless upload_webshell
        Severity: Minor
        Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method upload_webshell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def upload_webshell
    # randomize file name if option WEBSHELL is not set
    if datastore['WEBSHELL'].blank?
      @webshell_name = "#{Rex::Text.rand_text_alpha(8..16)}.php"
    else
        Severity: Minor
        Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            register_options(
      [
        OptString.new('TARGETURI', [ true, 'Craft CMS base url', '/' ]),
        OptString.new('WEBSHELL', [
          false, 'The name of the webshell with extension .php. Webshell name will be randomly generated if left unset.', ''
        Severity: Minor
        Found in modules/exploits/linux/http/craftcms_unauth_rce_cve_2023_41892.rb and 2 other locations - About 35 mins to fix
        modules/exploits/multi/http/monitorr_webshell_rce_cve_2020_28871.rb on lines 114..121
        modules/exploits/multi/http/sugarcrm_webshell_cve_2023_22952.rb on lines 104..111

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status