rapid7/metasploit-framework

View on GitHub
modules/exploits/linux/http/cve_2019_1663_cisco_rmi_rce.rb

Summary

Maintainability
D
2 days
Test Coverage

Method initialize has 238 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Cisco RV110W/RV130(W)/RV215W Routers Management Interface Remote Command Execution',
Severity: Major
Found in modules/exploits/linux/http/cve_2019_1663_cisco_rmi_rce.rb - About 1 day to fix

    File cve_2019_1663_cisco_rmi_rce.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
      Rank = GoodRanking
    
      include Msf::Exploit::Remote::HttpClient
      include Msf::Exploit::CmdStager
    Severity: Minor
    Found in modules/exploits/linux/http/cve_2019_1663_cisco_rmi_rce.rb - About 5 hrs to fix

      Method check has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
          # We fingerprint devices using SHA1 hash of a web resource accessible to unauthenticated users.
          # We use lang_pack/EN.js because it's the one file that changes the most between versions.
          # Note that it's not a smoking gun given that some branches keep the exact same files in /www
          # (see RV110 branch 1.2.1.x/1.2.2.x, RV130 > 1.0.3.22, RV215 1.2.0.x/1.3.x)
      Severity: Major
      Found in modules/exploits/linux/http/cve_2019_1663_cisco_rmi_rce.rb - About 2 hrs to fix

        Method prepare_shellcode has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def prepare_shellcode(cmd)
            case target
            # RV110W 1.1.0.9, 1.2.0.9, 1.2.0.10, 1.2.1.4, 1.2.1.7
            # RV215W 1.1.0.5, 1.1.0.6, 1.2.0.14, 1.2.0.15, 1.3.0.7, 1.3.0.8
            when targets[0], targets[1], targets[2], targets[3], targets[4], targets[6], targets[7], targets[8], targets[9], targets[10], targets[11]
        Severity: Minor
        Found in modules/exploits/linux/http/cve_2019_1663_cisco_rmi_rce.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status