Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/elfinder_archive_cmd_injection.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'elFinder Archive Command Injection',
Severity: Minor
Found in modules/exploits/linux/http/elfinder_archive_cmd_injection.rb - About 1 hr to fix

    Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    res = send_request_cgi(
      'method' => 'GET',
      'uri' => upload_uri
    )
    Severity: Minor
    Found in modules/exploits/linux/http/elfinder_archive_cmd_injection.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method upload_successful? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def upload_successful?(response)
    unless response
      print_bad('Did not receive a response from elFinder')
      return false
    end
    Severity: Minor
    Found in modules/exploits/linux/http/elfinder_archive_cmd_injection.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return CheckCode::Appears("elFinder running version #{vers_str[1]}")
    Severity: Major
    Found in modules/exploits/linux/http/elfinder_archive_cmd_injection.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status