Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/goahead_ldpreload.rb

Summary

Maintainability
D
2 days
Test Coverage

Method cycle_possible_payloads has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  def cycle_possible_payloads
    template_base = ::File.join(Msf::Config.data_directory, "exploits", "CVE-2017-17562")
    template_list = []
    template_type = nil
    template_arch = nil
Severity: Minor
Found in modules/exploits/linux/http/goahead_ldpreload.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_target_cgi has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def find_target_cgi

    target_uris = []
    common_dirs = %W^
/
Severity: Major
Found in modules/exploits/linux/http/goahead_ldpreload.rb - About 3 hrs to fix

    File goahead_ldpreload.rb has 299 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
    Severity: Minor
    Found in modules/exploits/linux/http/goahead_ldpreload.rb - About 3 hrs to fix

      Method initialize has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'           => 'GoAhead Web Server LD_PRELOAD Arbitrary Module Load',
      'Description'    => %q{
          This module triggers an arbitrary shared library load vulnerability
      Severity: Major
      Found in modules/exploits/linux/http/goahead_ldpreload.rb - About 2 hrs to fix

        Method cycle_possible_payloads has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def cycle_possible_payloads
    template_base = ::File.join(Msf::Config.data_directory, "exploits", "CVE-2017-17562")
    template_list = []
    template_type = nil
    template_arch = nil
        Severity: Major
        Found in modules/exploits/linux/http/goahead_ldpreload.rb - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              common_cgis = %W^
admin
apply
non-CA-rev
checkCookie
          Severity: Major
          Found in modules/exploits/linux/http/goahead_ldpreload.rb and 1 other location - About 1 hr to fix
          modules/auxiliary/admin/hp/hp_imc_som_create_account.rb on lines 135..199

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status