Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/huawei_hg532n_cmdinject.rb

Summary

Maintainability
D
1 day
Test Coverage

File huawei_hg532n_cmdinject.rb has 383 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'base64'

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking
Severity: Minor
Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 5 hrs to fix

    Class MetasploitModule has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::Remote::HttpServer
    Severity: Minor
    Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 2 hrs to fix

      Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(
      info,
      'Name'        => 'Huawei HG532n Command Injection',
      'Description' => %q(
      Severity: Major
      Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 2 hrs to fix

        Method expose_telnet_port has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def expose_telnet_port(session_cookies)
    cookie = generate_web_cookie(session: session_cookies)

    external_telnet_port = rand(32767) + 32768
        Severity: Minor
        Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 1 hr to fix

          Method read_until has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def read_until(sock, timeout, marker)
    received = ''
    Timeout.timeout(timeout) do
      loop do
        r = (sock.get_once(-1, 1) || '')
          Severity: Minor
          Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method check has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def check
    httpd_fingerprint = %r{
      \A
      HTTP\/1\.1\s200\sOK\r\n
      CACHE-CONTROL:\sno-cache\r\n
          Severity: Minor
          Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 1 hr to fix

            Method telnet_prompt_wait has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def telnet_prompt_wait(error_regex = nil)
    begin
      result = read_until(@telnet_sock, @telnet_timeout, @telnet_prompt)
      if error_regex
        error_regex = [error_regex] unless error_regex.is_a? Array
            Severity: Minor
            Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method web_login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def web_login
    cookie = generate_web_cookie(admin: true)

    # On good passwords, the router redirect us to the /html/content.asp
    # homepage. Otherwise, it throws us back to the '/' login page. Thus
            Severity: Minor
            Found in modules/exploits/linux/http/huawei_hg532n_cmdinject.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status