Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb

Summary

Maintainability
D
1 day
Test Coverage

File kibana_upgrade_assistant_telemetry_rce.rb has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking # causes service to not respond until cleanup and reboot
  include Msf::Exploit::Remote::HttpClient
  # decided not to use autocheck since it doesn't work for both targets
Severity: Minor
Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 3 hrs to fix

    Method mapping_data has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def mapping_data
    {
      'properties' => {
        'upgrade-assistant-telemetry' => {
          'properties' => {
    Severity: Major
    Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 2 hrs to fix

      Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Kibana Upgrade Assistant Telemetry Collector Prototype Pollution',
      Severity: Major
      Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 2 hrs to fix

        Method execute_command has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def execute_command
    case target.name
    when 'ELASTIC'
      request = {
        'uri' => normalize_uri(target_uri.path, '.kibana_1', '_doc', 'upgrade-assistant-telemetry:upgrade-assistant-telemetry'),
        Severity: Minor
        Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    if target == targets[0] # elastic
      return CheckCode::Unknown('Unable to determine Kibana version from Elastic database')
    end
          Severity: Minor
          Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def exploit
    @clean = true
    fail_with(Failure::BadConfig, 'A password has been defined without a username') if datastore['USERNAME'].blank? && !datastore['PASSWORD'].blank?
    case target.name
    when 'ELASTIC'
          Severity: Minor
          Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                return CheckCode::Appears("Exploitable Version Detected: #{@version}")
          Severity: Major
          Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return Exploit::CheckCode::Safe("#{peer} - Unexpected response, unable to determine version") if json_body['version'].nil?
            Severity: Major
            Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return Exploit::CheckCode::Safe("#{peer} - Unexpected response, unable to determine version")
              Severity: Major
              Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 30 mins to fix

                Method execute_command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def execute_command
    case target.name
    when 'ELASTIC'
      request = {
        'uri' => normalize_uri(target_uri.path, '.kibana_1', '_doc', 'upgrade-assistant-telemetry:upgrade-assistant-telemetry'),
                Severity: Minor
                Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    register_options(
      [
        Opt::RPORT(9200), # default to elastic port, kibana is 5601
        OptString.new('USERNAME', [ false, 'Elastic User to login with', '']),
        OptString.new('PASSWORD', [ false, 'Elastic Password to login with', '']),
                Severity: Minor
                Found in modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb and 4 other locations - About 15 mins to fix
                modules/auxiliary/gather/splunk_raw_server_info.rb on lines 38..44
                modules/auxiliary/scanner/http/chef_webui_login.rb on lines 34..40
                modules/exploits/windows/http/hp_sitescope_dns_tool.rb on lines 55..61
                modules/exploits/windows/http/pgadmin_binary_path_api.rb on lines 52..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status