Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/librenms_collectd_cmd_inject.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_device_ids has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def get_device_ids
    version = get_version
    print_status("LibreNMS version: #{version}")

    if version && Rex::Version.new(version) < Rex::Version.new('1.50')
Severity: Minor
Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'LibreNMS Collectd Command Injection',
      'Description'    => %q(
        This module exploits a command injection vulnerability in the
Severity: Minor
Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 1 hr to fix

    Method get_device_ids has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_device_ids
    version = get_version
    print_status("LibreNMS version: #{version}")

    if version && Rex::Version.new(version) < Rex::Version.new('1.50')
    Severity: Minor
    Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 1 hr to fix

      Method exploit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exploit
    req_uri = normalize_uri(target_uri.path, 'graph.php')
    @cookies = login

    dev_ids = get_device_ids
      Severity: Minor
      Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    res = send_request_cgi!('method'  =>  'GET', 'uri'  =>  target_uri.path)
    return Exploit::CheckCode::Safe unless res && res.body.downcase.include?('librenms')

    about_res = send_request_cgi(
        Severity: Minor
        Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def login
    login_uri = normalize_uri(target_uri.path, 'login')
    res = send_request_cgi('method' =>  'GET',  'uri' =>  login_uri)
    fail_with(Failure::NotFound, 'Failed to access the login page') unless res && res.code == 200
        Severity: Minor
        Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_version has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_version
    uri = normalize_uri(target_uri.path, 'about')

    res = send_request_cgi( 'method'  =>  'GET', 'uri' => uri, 'cookie' => @cookies )
    fail_with(Failure::NotFound, 'Failed to reach the about LibreNMS page') unless res && res.code == 200
        Severity: Minor
        Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          def login
    login_uri = normalize_uri(target_uri.path, 'login')
    res = send_request_cgi('method' =>  'GET',  'uri' =>  login_uri)
    fail_with(Failure::NotFound, 'Failed to access the login page') unless res && res.code == 200
        Severity: Major
        Found in modules/exploits/linux/http/librenms_collectd_cmd_inject.rb and 1 other location - About 2 hrs to fix
        modules/exploits/linux/http/librenms_addhost_cmd_inject.rb on lines 57..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status