Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb

Summary

Maintainability
F
3 days
Test Coverage

File linksys_wrt54gl_apply_exec.rb has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::Remote::HttpServer
Severity: Minor
Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 4 hrs to fix

    Method exploit has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    downfile = datastore['DOWNFILE'] || rand_text_alpha(8+rand(8))
    uri = '/apply.cgi'
    user = datastore['HttpUsername']
    pass = datastore['HttpPassword']
    Severity: Major
    Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 4 hrs to fix

      Method exploit has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    downfile = datastore['DOWNFILE'] || rand_text_alpha(8+rand(8))
    uri = '/apply.cgi'
    user = datastore['HttpUsername']
    pass = datastore['HttpPassword']
      Severity: Minor
      Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method grab_config has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def grab_config(user,pass)
    print_status("#{rhost}:#{rport} - Trying to download the original configuration")
    begin
      res = send_request_cgi({
        'uri'     => '/index.asp',
      Severity: Major
      Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 2 hrs to fix

        Method request has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def request(cmd,user,pass,uri)
    begin
      res = send_request_cgi({
        'uri'    => uri,
        'method' => 'POST',
        Severity: Major
        Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 2 hrs to fix

          Method initialize has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(info = {})
    super(update_info(info,
      'Name'    => 'Linksys WRT54GL apply.cgi Command Execution',
      'Description' => %q{
          Some Linksys Routers are vulnerable to an authenticated OS command injection in
          Severity: Major
          Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 2 hrs to fix

            Method grab_config has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def grab_config(user,pass)
    print_status("#{rhost}:#{rport} - Trying to download the original configuration")
    begin
      res = send_request_cgi({
        'uri'     => '/index.asp',
            Severity: Minor
            Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                begin
      res = send_request_cgi({
        'uri'     => '/index.asp',
        'method'  => 'GET',
        'authorization' => basic_auth(user,pass)
            Severity: Major
            Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb and 1 other location - About 2 hrs to fix
            modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 85..104

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                super(update_info(info,
      'Name'    => 'Linksys WRT54GL apply.cgi Command Execution',
      'Description' => %q{
          Some Linksys Routers are vulnerable to an authenticated OS command injection in
        the Web Interface. Default credentials are admin/admin or admin/password. Since it
            Severity: Major
            Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb and 1 other location - About 1 hr to fix
            modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 15..68

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

              def wait_linux_payload
    print_status("#{rhost}:#{rport} - Waiting for the victim to request the ELF payload...")

    waited = 0
    while (not @elf_sent)
            Severity: Major
            Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb and 7 other locations - About 45 mins to fix
            modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 210..218
            modules/exploits/linux/http/dlink_dir615_up_exec.rb on lines 245..253
            modules/exploits/linux/http/linksys_e1500_apply_exec.rb on lines 238..246
            modules/exploits/linux/http/netgear_dgn1000b_setup_exec.rb on lines 242..250
            modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 347..355
            modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 71..79
            modules/exploits/multi/sap/sap_mgmt_con_osexec_payload.rb on lines 310..318

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 11 locations. Consider refactoring.
            Open

              def on_request_uri(cli, request)
    #print_status("on_request_uri called: #{request.inspect}")
    if (not @pl)
      print_error("#{rhost}:#{rport} - A request came in, but the payload wasn't ready yet!")
      return
            Severity: Major
            Found in modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb and 10 other locations - About 20 mins to fix
            modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 198..206
            modules/exploits/linux/http/dlink_dir615_up_exec.rb on lines 233..241
            modules/exploits/linux/http/linksys_e1500_apply_exec.rb on lines 226..234
            modules/exploits/linux/http/netgear_dgn1000b_setup_exec.rb on lines 230..238
            modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 335..343
            modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 85..92
            modules/exploits/multi/http/bassmaster_js_injection.rb on lines 87..94
            modules/exploits/multi/http/rails_dynamic_render_code_exec.rb on lines 95..102
            modules/exploits/multi/http/trendmicro_threat_discovery_admin_sys_time_cmdi.rb on lines 137..144
            modules/exploits/multi/sap/sap_mgmt_con_osexec_payload.rb on lines 298..306

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status