Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/nagios_xi_configwizards_authenticated_rce.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Nagios XI 5.5.6 to 5.7.5 - ConfigWizards Authenticated Remote Code Exection',
Severity: Major
Found in modules/exploits/linux/http/nagios_xi_configwizards_authenticated_rce.rb - About 2 hrs to fix

    Method execute_command has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def execute_command(cmd, _opts = {})
    if !@nsp || !@auth_cookies # Check to see if we already authenticated during the check
      auth_result, err_msg, @auth_cookies, @version, @nsp = authenticate(username, password, finish_install, true, true, true)
      case auth_result
      when AUTH_RESULTS[:connection_failed]
    Severity: Major
    Found in modules/exploits/linux/http/nagios_xi_configwizards_authenticated_rce.rb - About 2 hrs to fix

      Method execute_command has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def execute_command(cmd, _opts = {})
    if !@nsp || !@auth_cookies # Check to see if we already authenticated during the check
      auth_result, err_msg, @auth_cookies, @version, @nsp = authenticate(username, password, finish_install, true, true, true)
      case auth_result
      when AUTH_RESULTS[:connection_failed]
      Severity: Minor
      Found in modules/exploits/linux/http/nagios_xi_configwizards_authenticated_rce.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

          return CheckCode::Safe
      Severity: Major
      Found in modules/exploits/linux/http/nagios_xi_configwizards_authenticated_rce.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status