Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Nagios XI Prior to 5.8.0 - Plugins Filename Authenticated Remote Code Exection',
Severity: Major
Found in modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb - About 2 hrs to fix

    Method exploit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    unless @auth_cookies.present?
      auth_result, err_msg, @auth_cookies, @version = authenticate(username, password, finish_install)
      case auth_result
      when AUTH_RESULTS[:connection_failed]
    Severity: Minor
    Found in modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    unless @auth_cookies.present?
      auth_result, err_msg, @auth_cookies, @version = authenticate(username, password, finish_install)
      case auth_result
      when AUTH_RESULTS[:connection_failed]
    Severity: Minor
    Found in modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

          return CheckCode::Safe
      Severity: Major
      Found in modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def check
    # Use nagios_xi_login to try and authenticate. If authentication succeeds, nagios_xi_login returns
    # an array containing the http response body of a get request to index.php and the session cookies
    auth_result, err_msg, @auth_cookies, @version = authenticate(username, password, finish_install)
    case auth_result
        Severity: Major
        Found in modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb and 1 other location - About 1 hr to fix
        modules/exploits/linux/http/nagios_xi_plugins_check_plugin_authenticated_rce.rb on lines 115..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            unless @auth_cookies.present?
      auth_result, err_msg, @auth_cookies, @version = authenticate(username, password, finish_install)
      case auth_result
      when AUTH_RESULTS[:connection_failed]
        return CheckCode::Unknown(err_msg)
        Severity: Major
        Found in modules/exploits/linux/http/nagios_xi_plugins_filename_authenticated_rce.rb and 2 other locations - About 1 hr to fix
        modules/exploits/linux/http/nagios_xi_mibs_authenticated_rce.rb on lines 109..117
        modules/exploits/linux/http/nagios_xi_plugins_check_plugin_authenticated_rce.rb on lines 226..234

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status