Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/opentsdb_key_cmd_injection.rb

Summary

Maintainability
D
2 days
Test Coverage

Method initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'OpenTSDB 2.4.1 unauthenticated command injection',
Severity: Major
Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 2 hrs to fix

    Method check has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    # sanity check to see if the target is likely OpenTSDB
    res1 = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)
    Severity: Minor
    Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    # sanity check to see if the target is likely OpenTSDB
    res1 = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)
    Severity: Minor
    Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 1 hr to fix

      Method execute_command has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def execute_command(cmd, _opts = {})
    # we need to percent encode the entire command.
    # however, the + character cannot be used and percent encoding does not help for it. so we need to change chmod +x with chmod 744
    cmd = CGI.escape(cmd.gsub('chmod +x', 'chmod 744'))
    start_time = rand(20.year.ago..10.year.ago) # this should be a date far enough in the past to make sure we capture all possible data
      Severity: Minor
      Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 1 hr to fix

        Method select_metric has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def select_metric
    # check if any metrics have been configured. if not, exploitation cannot work
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'suggest'),
        Severity: Minor
        Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method select_aggregator has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def select_aggregator
    # check the configured aggregators and select one at random
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'aggregators')
        Severity: Minor
        Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return CheckCode::Detected('Could not determine the OpenTSDB version: the HTTP response body did not match the expected JSON format.')
        Severity: Major
        Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Detected('Could not determine the OpenTSDB version: the HTTP response body did not match the expected JSON format.')
          Severity: Major
          Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Unknown("Failed to obtain a valid OpenTSDB version: #{e}")
            Severity: Major
            Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return CheckCode::Appears("The target is OpenTSDB version #{version}")
              Severity: Major
              Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return CheckCode::Safe("The target is OpenTSDB version #{version}")
                Severity: Major
                Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def check
    # sanity check to see if the target is likely OpenTSDB
    res1 = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)
                  Severity: Major
                  Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb and 1 other location - About 3 hrs to fix
                  modules/exploits/linux/http/opentsdb_yrange_cmd_injection.rb on lines 87..136

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 129.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def select_metric
    # check if any metrics have been configured. if not, exploitation cannot work
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'suggest'),
                  Severity: Major
                  Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb and 1 other location - About 1 hr to fix
                  modules/exploits/linux/http/opentsdb_yrange_cmd_injection.rb on lines 139..171

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def select_aggregator
    # check the configured aggregators and select one at random
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'aggregators')
                  Severity: Major
                  Found in modules/exploits/linux/http/opentsdb_key_cmd_injection.rb and 1 other location - About 1 hr to fix
                  modules/exploits/linux/http/opentsdb_yrange_cmd_injection.rb on lines 174..205

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 71.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status