Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/optergy_bms_backdoor_rce_cve_2019_7276.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Optergy Proton and Enterprise BMS Command Injection using a backdoor',
Severity: Major
Found in modules/exploits/linux/http/optergy_bms_backdoor_rce_cve_2019_7276.rb - About 2 hrs to fix

    Method execute_command has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def execute_command(cmd, _opts = {})
    # Step 1: get the challenge and compute the response answer for the backdoor execution
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, '/tools/ajax/ConsoleResult.html?get')
    Severity: Minor
    Found in modules/exploits/linux/http/optergy_bms_backdoor_rce_cve_2019_7276.rb - About 1 hr to fix

      Method execute_command has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def execute_command(cmd, _opts = {})
    # Step 1: get the challenge and compute the response answer for the backdoor execution
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, '/tools/ajax/ConsoleResult.html?get')
      Severity: Minor
      Found in modules/exploits/linux/http/optergy_bms_backdoor_rce_cve_2019_7276.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return res_cmd_output
      Severity: Major
      Found in modules/exploits/linux/http/optergy_bms_backdoor_rce_cve_2019_7276.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status