Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/pandora_fms_sqli.rb

Summary

Maintainability
C
1 day
Test Coverage

Method upload has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def upload
    # Extract hash and hash2 from response
    res = send_request_cgi({
      'method' => 'GET',
      'cookie' => @cookie,
Severity: Major
Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 2 hrs to fix

    File pandora_fms_sqli.rb has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::FileDropper
    Severity: Minor
    Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 2 hrs to fix

      Method upload has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def upload
    # Extract hash and hash2 from response
    res = send_request_cgi({
      'method' => 'GET',
      'cookie' => @cookie,
      Severity: Minor
      Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info={})
    super(update_info(info,
      'Name'           => 'Pandora FMS Default Credential / SQLi Remote Code Execution',
      'Description'    => %q{
        This module attempts to exploit multiple issues in order to gain remote
      Severity: Minor
      Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 1 hr to fix

        Method login_hash has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def login_hash
    clue = rand_text_alpha(8)
    sql_clue = clue.each_byte.map { |b| b.to_s(16) }.join
    # select value from tconfig where token = 'loginhash_pwd';
    sqli = "1' AND (SELECT 2243 FROM(SELECT COUNT(*),CONCAT(0x#{sql_clue},(SELECT MID((IFNULL(CAST"
        Severity: Minor
        Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    vprint_status("Trying to detect installed version")

    version = nil
    res = send_request_cgi({
          Severity: Minor
          Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method auth_succeeded? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def auth_succeeded?(res)
    if res && res.code == 200 && res.body.include?('Welcome to Pandora FMS')
      print_good("Successfully authenticated")
      print_status("Attempting to retrieve session cookie")
      @cookie = res.get_cookies
          Severity: Minor
          Found in modules/exploits/linux/http/pandora_fms_sqli.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def authenticate
    res = send_request_cgi({
      'method' => 'POST',
      'uri' => normalize_uri(uri, 'index.php'),
      'vars_get' => {
          Severity: Minor
          Found in modules/exploits/linux/http/pandora_fms_sqli.rb and 1 other location - About 25 mins to fix
          modules/exploits/linux/http/pandora_ping_cmd_exec.rb on lines 79..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 30.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status