Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/panos_op_cmd_exec.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Palo Alto Networks Authenticated Remote Code Execution',
Severity: Major
Found in modules/exploits/linux/http/panos_op_cmd_exec.rb - About 2 hrs to fix

    Method api_key has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def api_key
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'api/'),
      'vars_get' => {
    Severity: Minor
    Found in modules/exploits/linux/http/panos_op_cmd_exec.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    print_status('Authenticating...')
    begin
      @api_key = api_key
    rescue InvalidRequest, InvalidResponse => e
      Severity: Minor
      Found in modules/exploits/linux/http/panos_op_cmd_exec.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

          if version >= Rex::Version.new('9.0.0') && version < Rex::Version.new('9.0.10') ||
       version >= Rex::Version.new('9.1.0') && version < Rex::Version.new('9.1.4') ||
       version >= Rex::Version.new('10.0.0') && version < Rex::Version.new('10.0.1')
      return Exploit::CheckCode::Appears
    end
      Severity: Major
      Found in modules/exploits/linux/http/panos_op_cmd_exec.rb - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status