Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/panos_telemetry_cmd_exec.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Palo Alto Networks PAN-OS Unauthenticated Remote Code Execution',
Severity: Major
Found in modules/exploits/linux/http/panos_telemetry_cmd_exec.rb - About 2 hrs to fix

    Method check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    # Try to create a new empty file in an accessible directory with the exploit primitive
    # This file name was chosen because an extension in (css|js|eot|woff|woff2|ttf) is required for correct NGINX routing, and similarly named files already exist in the 'fonts' directory
    file_check_name = "glyphicons-#{Rex::Text.rand_text_alpha_lower(8)}-regular.woff2"
    touch_file("/var/appweb/sslvpndocs/global-protect/portal/fonts/#{file_check_name}")
    Severity: Minor
    Found in modules/exploits/linux/http/panos_telemetry_cmd_exec.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status