Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb

Summary

Maintainability
D
1 day
Test Coverage

Method on_new_session has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def on_new_session(session)
    payload_instance.stop_handler
    super

    # The Python script is being cached in the "__pycache__" directory as a
Severity: Minor
Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'SaltStack Salt API Unauthenticated RCE through wheel_async client',
Severity: Major
Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb - About 3 hrs to fix

    Method on_new_session has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def on_new_session(session)
    payload_instance.stop_handler
    super

    # The Python script is being cached in the "__pycache__" directory as a
    Severity: Minor
    Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb - About 1 hr to fix

      Method path_exists? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def path_exists?(session, path, is_dir: false)
    if session.type == 'meterpreter'
      path_exists = begin
        session.fs.file.stat(path)
      rescue StandardError
      Severity: Minor
      Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    fun = 'config.values'
    res = send_request(fun: fun)

    unless res
      Severity: Minor
      Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

                  'Unix Command',
            {
              'Platform' => 'unix',
              'Arch' => ARCH_CMD,
              'Type' => :unix_cmd,
      Severity: Major
      Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb and 8 other locations - About 25 mins to fix
      modules/exploits/linux/http/apache_ofbiz_deserialization.rb on lines 51..72
      modules/exploits/linux/http/apache_ofbiz_deserialization_soap.rb on lines 47..68
      modules/exploits/linux/http/f5_bigip_tmui_rce_cve_2020_5902.rb on lines 53..74
      modules/exploits/linux/http/f5_icontrol_rce.rb on lines 46..67
      modules/exploits/linux/http/f5_icontrol_rest_ssrf_rce.rb on lines 59..80
      modules/exploits/linux/http/mobileiron_mdm_hessian_rce.rb on lines 43..64
      modules/exploits/linux/http/saltstack_salt_api_cmd_exec.rb on lines 46..67
      modules/exploits/unix/webapp/thinkphp_rce.rb on lines 47..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def exploit
    print_status("Executing #{target.name} for #{datastore['PAYLOAD']}")

    case target['Type']
    when :unix_cmd
      Severity: Minor
      Found in modules/exploits/linux/http/saltstack_salt_wheel_async_rce.rb and 1 other location - About 25 mins to fix
      modules/exploits/linux/http/saltstack_salt_api_cmd_exec.rb on lines 108..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status