Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/samsung_srv_1670d_upload_exec.rb

Summary

Maintainability
D
1 day
Test Coverage

Method exploit has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    print_status('Obtaining credentails...')

    resp = send_request_cgi({
      'uri'      => '/cslog_export.php',
Severity: Minor
Found in modules/exploits/linux/http/samsung_srv_1670d_upload_exec.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    print_status('Obtaining credentails...')

    resp = send_request_cgi({
      'uri'      => '/cslog_export.php',
Severity: Major
Found in modules/exploits/linux/http/samsung_srv_1670d_upload_exec.rb - About 4 hrs to fix

    Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Samsung SRN-1670D Web Viewer Version 1.0.0.193 Arbitrary File Read and Upload',
      'Description'    => %q{
        This module exploits an unrestricted file upload vulnerability in
    Severity: Minor
    Found in modules/exploits/linux/http/samsung_srv_1670d_upload_exec.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    vprint_status('Checking version...')

    resp = send_request_cgi({
      'uri'    =>  "/index",
      Severity: Minor
      Found in modules/exploits/linux/http/samsung_srv_1670d_upload_exec.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status