Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has 141 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit

    # Step 1 - Establish a session with the target which will give us a PHP object we can
    # work with.
    begin
Severity: Major
Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb - About 5 hrs to fix

    Method exploit has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit

    # Step 1 - Establish a session with the target which will give us a PHP object we can
    # work with.
    begin
    Severity: Minor
    Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Seagate Business NAS Unauthenticated Remote Command Execution',
      'Description'    => %q{
        Some Seagate Business NAS devices are vulnerable to command execution via a local
    Severity: Minor
    Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    begin
      res = send_request_cgi(
        'uri'      => normalize_uri(target_uri),
        'method'   => 'GET',
      Severity: Minor
      Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

          register_options([
        OptString.new('TARGETURI', [true, 'Path to the application root', '/']),
        OptString.new('ADMINACCOUNT', [true, 'Name of the NAS admin account', 'admin']),
        OptString.new('COOKIEID', [true, 'ID of the CodeIgniter session cookie', 'ci_session']),
        OptString.new('XORKEY', [true, 'XOR Key used for the CodeIgniter session', '0f0a000d02011f0248000d290d0b0b0e03010e07'])
      Severity: Major
      Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb and 16 other locations - About 25 mins to fix
      modules/auxiliary/admin/http/joomla_registration_privesc.rb on lines 35..41
      modules/auxiliary/admin/http/kaseya_master_admin.rb on lines 36..42
      modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb on lines 35..41
      modules/auxiliary/gather/mantisbt_admin_sqli.rb on lines 33..39
      modules/auxiliary/scanner/http/riverbed_steelhead_vcx_file_read.rb on lines 31..37
      modules/auxiliary/scanner/sap/sap_soap_rfc_pfl_check_os_file_existence.rb on lines 51..56
      modules/auxiliary/scanner/sap/sap_soap_rfc_rzl_read_dir.rb on lines 51..56
      modules/auxiliary/scanner/telephony/wardial.rb on lines 48..54
      modules/exploits/linux/http/froxlor_log_path_rce.rb on lines 67..73
      modules/exploits/unix/webapp/wp_google_document_embedder_exec.rb on lines 53..59
      modules/exploits/windows/http/ajaxpro_deserialization_rce.rb on lines 91..96
      modules/exploits/windows/http/apache_activemq_traversal_upload.rb on lines 61..66
      modules/exploits/windows/http/manageengine_adaudit_plus_authenticated_rce.rb on lines 89..94
      modules/exploits/windows/http/sharepoint_data_deserialization.rb on lines 77..82
      modules/exploits/windows/http/zentao_pro_rce.rb on lines 74..79
      modules/post/osx/manage/mount_share.rb on lines 51..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            res = send_request_cgi(
        'uri'             => normalize_uri(target_uri, 'index.php/mv_system/set_general_setup'),
        'method'          => 'POST',
        'headers'         => {
          'Accept'        => 'text/html'
      Severity: Minor
      Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb and 1 other location - About 25 mins to fix
      modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb on lines 266..279

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          res = send_request_cgi(
      'uri'             => normalize_uri(target_uri, 'index.php/mv_system/set_general_setup'),
      'method'          => 'POST',
      'headers'         => {
        'Accept'        => 'text/html'
      Severity: Minor
      Found in modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb and 1 other location - About 25 mins to fix
      modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb on lines 207..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status