rapid7/metasploit-framework

View on GitHub
modules/exploits/linux/http/symantec_messaging_gateway_exec.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => "Symantec Messaging Gateway Remote Code Execution",
      'Description'    => %q{
        This module exploits the command injection vulnerability of Symantec Messaging Gateway product. An authenticated user can execute a
Severity: Minor
Found in modules/exploits/linux/http/symantec_messaging_gateway_exec.rb - About 1 hr to fix

    Method auth has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def auth
        print_status("Performing authentication...")
    
        sid        = ''
        last_login = ''
    Severity: Minor
    Found in modules/exploits/linux/http/symantec_messaging_gateway_exec.rb - About 1 hr to fix

      Method exploit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exploit
      
          cookie = auth
          csrf_token = get_csrf_token(cookie)
      
      
      Severity: Minor
      Found in modules/exploits/linux/http/symantec_messaging_gateway_exec.rb - About 1 hr to fix

        Method auth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def auth
            print_status("Performing authentication...")
        
            sid        = ''
            last_login = ''
        Severity: Minor
        Found in modules/exploits/linux/http/symantec_messaging_gateway_exec.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_csrf_token has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_csrf_token(cookie)
        
            print_status('Capturing CSRF token')
        
            res = send_request_cgi({
        Severity: Minor
        Found in modules/exploits/linux/http/symantec_messaging_gateway_exec.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status