Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/trendmicro_sps_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method login has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def login
    uri = target_uri.path
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(uri, 'index.php'),
Severity: Minor
Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 1 hr to fix

    Method check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    opts = login
    if opts
      uri = target_uri.path
      res = send_request_cgi({
    Severity: Minor
    Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => "Trend Micro Smart Protection Server Exec Remote Code Injection",
      'Description'    => %q{
        This module exploits a vulnerability found in TrendMicro Smart Protection Server where untrusted inputs are fed to ServWebExec system command, leading to command injection.
    Severity: Minor
    Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 1 hr to fix

      Method check has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    opts = login
    if opts
      uri = target_uri.path
      res = send_request_cgi({
      Severity: Minor
      Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 1 hr to fix

        Method execute_command has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def execute_command(cmd, opts = {})
    uri = target_uri.path
    send_request_cgi({
      'method' => 'POST',
      'version' => '1.0',
        Severity: Minor
        Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                  if (version == 3.0 and build < 1330) or
          (version == 2.6 and build < 2106) or
          (version == 2.5 and build < 2200)
            return Exploit::CheckCode::Vulnerable
        else
          Severity: Major
          Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 40 mins to fix

            Method login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def login
    uri = target_uri.path
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(uri, 'index.php'),
            Severity: Minor
            Found in modules/exploits/linux/http/trendmicro_sps_exec.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  {
        'Cookie' => "#{opts["sid"]}=#{opts["sid_value"]}",
        'Referer' => "https://#{datastore['RHOST']}:#{datastore['RPORT']}/login.php",
        'Origin' =>  "https://#{datastore['RHOST']}:#{datastore['RPORT']}",
            Severity: Minor
            Found in modules/exploits/linux/http/trendmicro_sps_exec.rb and 1 other location - About 35 mins to fix
            modules/exploits/linux/http/trendmicro_sps_exec.rb on lines 63..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 35.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    {
          'Cookie' => "#{opts["sid"]}=#{opts["sid_value"]}",
          'Referer' => "https://#{datastore['RHOST']}:#{datastore['RPORT']}/login.php",
          'Origin' =>  "https://#{datastore['RHOST']}:#{datastore['RPORT']}",
            Severity: Minor
            Found in modules/exploits/linux/http/trendmicro_sps_exec.rb and 1 other location - About 35 mins to fix
            modules/exploits/linux/http/trendmicro_sps_exec.rb on lines 97..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 35.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status