Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/vestacp_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method login has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def login
    #
    # This is very simple login process. Nothing important.
    # We will be using cookie and csrf_token across the module as instance variables.
    #
Severity: Minor
Found in modules/exploits/linux/http/vestacp_exec.rb - About 1 hr to fix

    Method login has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def login
    #
    # This is very simple login process. Nothing important.
    # We will be using cookie and csrf_token across the module as instance variables.
    #
    Severity: Minor
    Found in modules/exploits/linux/http/vestacp_exec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start_backup_and_trigger_payload has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def start_backup_and_trigger_payload
    #
    # Once a scheduled backup is triggered, the v-backup-user script will be executed.
    # This script will take the file name that we provided and will insert it into backup.conf
    # so that the backup process can be performed correctly.
    Severity: Minor
    Found in modules/exploits/linux/http/vestacp_exec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Vesta Control Panel Authenticated Remote Code Execution',
    Severity: Minor
    Found in modules/exploits/linux/http/vestacp_exec.rb - About 1 hr to fix

      Method start_backup_and_trigger_payload has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def start_backup_and_trigger_payload
    #
    # Once a scheduled backup is triggered, the v-backup-user script will be executed.
    # This script will take the file name that we provided and will insert it into backup.conf
    # so that the backup process can be performed correctly.
      Severity: Minor
      Found in modules/exploits/linux/http/vestacp_exec.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status