Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb

Summary

Maintainability
D
1 day
Test Coverage

Method on_new_session has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def on_new_session(session)
    if session.type.to_s.eql? 'meterpreter'
      session.core.use 'stdapi' unless session.ext.aliases.include? 'stdapi'
    end
Severity: Minor
Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'ABRT raceabrt Privilege Escalation',
Severity: Major
Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 2 hrs to fix

    Method on_new_session has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def on_new_session(session)
    if session.type.to_s.eql? 'meterpreter'
      session.core.use 'stdapi' unless session.ext.aliases.include? 'stdapi'
    end
    Severity: Minor
    Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 1 hr to fix

      Method check has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    if immutable?('/etc/passwd')
      vprint_error 'File /etc/passwd is immutable'
      return CheckCode::Safe
    end
      Severity: Minor
      Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 1 hr to fix

        Method exploit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def exploit
    if check != CheckCode::Detected
      fail_with Failure::NotVulnerable, 'Target is not vulnerable'
    end
        Severity: Minor
        Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    if immutable?('/etc/passwd')
      vprint_error 'File /etc/passwd is immutable'
      return CheckCode::Safe
    end
          Severity: Minor
          Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                return CheckCode::Safe
          Severity: Major
          Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                      [ 'CVE', '2015-3315' ],
          [ 'EDB', '36747' ],
          [ 'BID', '75117' ],
          [ 'URL', 'https://gist.github.com/taviso/fe359006836d6cd1091e' ],
          [ 'URL', 'http://www.openwall.com/lists/oss-security/2015/04/14/4' ],
            Severity: Major
            Found in modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb and 3 other locations - About 45 mins to fix
            modules/exploits/linux/local/nested_namespace_idmap_limit_priv_esc.rb on lines 50..62
            modules/exploits/multi/http/jenkins_metaprogramming.rb on lines 43..55
            modules/exploits/windows/smb/smb_doublepulsar_rce.rb on lines 36..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status