Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/apt_package_manager_persistence.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'APT Package Manager Persistence',
      'Description'    => %q(
        This module will run a payload when the package manager is used. No
Severity: Minor
Found in modules/exploits/linux/local/apt_package_manager_persistence.rb - About 1 hr to fix

    Method exploit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    hook_path = '/etc/apt/apt.conf.d/'
    unless writable? hook_path
      fail_with Failure::BadConfig, "#{hook_path} not writable, or APT is not on system"
    end
    Severity: Minor
    Found in modules/exploits/linux/local/apt_package_manager_persistence.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    hook_path = '/etc/apt/apt.conf.d/'
    unless writable? hook_path
      fail_with Failure::BadConfig, "#{hook_path} not writable, or APT is not on system"
    end
    Severity: Minor
    Found in modules/exploits/linux/local/apt_package_manager_persistence.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status