Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/bpf_priv_esc.rb

Summary

Maintainability
F
3 days
Test Coverage

Method exploit has 223 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
Severity: Major
Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 1 day to fix

    File bpf_priv_esc.rb has 446 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Local
  Rank = GoodRanking

  include Msf::Post::File
  include Msf::Post::Linux::Priv
    Severity: Minor
    Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 6 hrs to fix

      Method initialize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Linux BPF doubleput UAF Privilege Escalation',
      Severity: Major
      Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 2 hrs to fix

        Method check has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check
    release = kernel_release
    version = kernel_version

    if Rex::Version.new(release.split('-').first) < Rex::Version.new('4.4') ||
        Severity: Minor
        Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    release = kernel_release
    version = kernel_version

    if Rex::Version.new(release.split('-').first) < Rex::Version.new('4.4') ||
          Severity: Minor
          Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method has_prereqs? has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def has_prereqs?
    def check_libfuse_dev?
      lib = cmd_exec('dpkg --get-selections | grep libfuse-dev')
      if lib.include?('install')
        vprint_good('libfuse-dev is installed')
          Severity: Minor
          Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 1 hr to fix

            Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
            Severity: Minor
            Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Unknown
            Severity: Major
            Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return CheckCode::Safe
              Severity: Major
              Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return CheckCode::Safe
                Severity: Major
                Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 30 mins to fix

                  Method live_compile? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def live_compile?
    return false unless datastore['COMPILE'].eql?('Auto') || datastore['COMPILE'].eql?('True')

    return true if has_prereqs?
                  Severity: Minor
                  Found in modules/exploits/linux/local/bpf_priv_esc.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def upload_and_compile(path, data, gcc_args = '')
    upload "#{path}.c", data

    gcc_cmd = "gcc -o #{path} #{path}.c"
    if session.type.eql? 'shell'
                  Severity: Major
                  Found in modules/exploits/linux/local/bpf_priv_esc.rb and 1 other location - About 1 hr to fix
                  modules/exploits/linux/local/vmware_alsa_config.rb on lines 100..120

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 22 locations. Consider refactoring.
                  Open

                            ['BID', '90309'],
          ['CVE', '2016-4557'],
          ['EDB', '39772'],
          ['URL', 'https://bugs.chromium.org/p/project-zero/issues/detail?id=808'],
          ['URL', 'https://usn.ubuntu.com/2965-1/'],
                  Severity: Major
                  Found in modules/exploits/linux/local/bpf_priv_esc.rb and 21 other locations - About 20 mins to fix
                  modules/auxiliary/dos/http/hashcollision_dos.rb on lines 36..44
                  modules/auxiliary/scanner/http/wp_woocommerce_payments_add_user.rb on lines 61..69
                  modules/exploits/android/browser/webview_addjavascriptinterface.rb on lines 58..66
                  modules/exploits/freebsd/local/rtld_execl_priv_esc.rb on lines 57..65
                  modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 32..40
                  modules/exploits/linux/http/zimbra_cpio_cve_2022_41352.rb on lines 44..52
                  modules/exploits/linux/local/cve_2021_3490_ebpf_alu32_bounds_check_lpe.rb on lines 53..61
                  modules/exploits/linux/local/glibc_realpath_priv_esc.rb on lines 48..56
                  modules/exploits/linux/local/systemtap_modprobe_options_priv_esc.rb on lines 43..51
                  modules/exploits/linux/misc/cisco_ios_xe_rce.rb on lines 52..65
                  modules/exploits/linux/misc/lprng_format_string.rb on lines 26..34
                  modules/exploits/linux/upnp/dlink_upnp_msearch_exec.rb on lines 70..78
                  modules/exploits/multi/browser/java_jre17_exec.rb on lines 43..51
                  modules/exploits/multi/http/git_client_command_exec.rb on lines 47..55
                  modules/exploits/multi/http/vtiger_soap_upload.rb on lines 33..41
                  modules/exploits/windows/browser/ms13_022_silverlight_script_object.rb on lines 40..48
                  modules/exploits/windows/browser/webex_ucf_newobject.rb on lines 40..48
                  modules/exploits/windows/fileformat/allplayer_m3u_bof.rb on lines 31..39
                  modules/exploits/windows/http/exchange_chainedserializationbinder_rce.rb on lines 45..54
                  modules/exploits/windows/http/exchange_ecp_dlp_policy.rb on lines 49..57
                  modules/exploits/windows/http/netgear_nms_rce.rb on lines 32..40

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 28.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status