rapid7/metasploit-framework

View on GitHub
modules/exploits/linux/local/cve_2021_3493_overlayfs.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => '2021 Ubuntu Overlayfs LPE',
Severity: Major
Found in modules/exploits/linux/local/cve_2021_3493_overlayfs.rb - About 2 hrs to fix

    Method exploit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
        if !datastore['ForceExploit'] && is_root?
          fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
        end
    
    
    Severity: Major
    Found in modules/exploits/linux/local/cve_2021_3493_overlayfs.rb - About 2 hrs to fix

      Method exploit has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
          if !datastore['ForceExploit'] && is_root?
            fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
          end
      
      
      Severity: Minor
      Found in modules/exploits/linux/local/cve_2021_3493_overlayfs.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
          arch = kernel_hardware
      
          unless arch.include?('x86_64') || arch.include?('aarch64')
            return CheckCode::Safe("System architecture #{arch} is not supported")
      Severity: Minor
      Found in modules/exploits/linux/local/cve_2021_3493_overlayfs.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
            arch = kernel_hardware
        
            unless arch.include?('x86_64') || arch.include?('aarch64')
              return CheckCode::Safe("System architecture #{arch} is not supported")
        Severity: Minor
        Found in modules/exploits/linux/local/cve_2021_3493_overlayfs.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return CheckCode::Appears
        Severity: Major
        Found in modules/exploits/linux/local/cve_2021_3493_overlayfs.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status