Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb

Summary

Maintainability
D
1 day
Test Coverage

Method inject_payload has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def inject_payload(payload)
    if session.type == 'meterpreter'
      socket_subsystem, socket = open_tcp_connection

      tcp_conversation = {
Severity: Minor
Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method inject_payload has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def inject_payload(payload)
    if session.type == 'meterpreter'
      socket_subsystem, socket = open_tcp_connection

      tcp_conversation = {
Severity: Major
Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 2 hrs to fix

    Method initialize has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Exim 4.87 - 4.91 Local Privilege Escalation',
    Severity: Major
    Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 2 hrs to fix

      Method check has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    if session.type == 'meterpreter'
      begin
        socket_subsystem, socket = open_tcp_connection
      rescue StandardError
      Severity: Minor
      Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
      Severity: Minor
      Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    if session.type == 'meterpreter'
      begin
        socket_subsystem, socket = open_tcp_connection
      rescue StandardError
      Severity: Minor
      Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 1 hr to fix

        Method exploit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
        Severity: Minor
        Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                  return CheckCode::Safe
          Severity: Major
          Found in modules/exploits/linux/local/exim4_deliver_message_priv_esc.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status