Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/glibc_tunables_priv_esc.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Glibc Tunables Privilege Escalation CVE-2023-4911 (aka Looney Tunables)',
Severity: Major
Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb - About 2 hrs to fix

    Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    glibc_version = cmd_exec('ldd --version')&.scan(/ldd\s+\(\w+\s+GLIBC\s+(\S+)\)/)&.flatten&.first
    return CheckCode::Unknown('Could not get the version of glibc') unless glibc_version

    sysinfo = get_sysinfo
    Severity: Minor
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_ld_so_build_id_readelf has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_ld_so_build_id_readelf
    file_cmd_output = ''

    # This needs to be split up by distro as Ubuntu has readlink and which installed by default but "ld.so" is not
    # defined on the path like it is on Debian. Also Ubuntu doesn't have ldconfig install by default.
    Severity: Minor
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_ld_so_build_id_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_ld_so_build_id_file
    file_cmd_output = ''

    # This needs to be split up by distro as Ubuntu has readlink and which installed by default but "ld.so" is not
    # defined on the path like it is on Debian. Also Ubuntu doesn't have ldconfig install by default.
    Severity: Minor
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_ld_so_build_id_perf has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_ld_so_build_id_perf
    perf_cmd_output = ''

    # This needs to be split up by distro as Ubuntu has readlink and which installed by default but "ld.so" is not
    # defined on the path like it is on Debian. Also Ubuntu doesn't have ldconfig install by default.
    Severity: Minor
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def check_ld_so_build_id_readelf
    file_cmd_output = ''

    # This needs to be split up by distro as Ubuntu has readlink and which installed by default but "ld.so" is not
    # defined on the path like it is on Debian. Also Ubuntu doesn't have ldconfig install by default.
    Severity: Major
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb and 2 other locations - About 1 hr to fix
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 167..192
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 196..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def check_ld_so_build_id_file
    file_cmd_output = ''

    # This needs to be split up by distro as Ubuntu has readlink and which installed by default but "ld.so" is not
    # defined on the path like it is on Debian. Also Ubuntu doesn't have ldconfig install by default.
    Severity: Major
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb and 2 other locations - About 1 hr to fix
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 138..163
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 196..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def check_ld_so_build_id_perf
    perf_cmd_output = ''

    # This needs to be split up by distro as Ubuntu has readlink and which installed by default but "ld.so" is not
    # defined on the path like it is on Debian. Also Ubuntu doesn't have ldconfig install by default.
    Severity: Major
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb and 2 other locations - About 1 hr to fix
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 138..163
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 167..192

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

             Rex::Version.new(test_version).between?(Rex::Version.new('2.37'), Rex::Version.new('2.37.2.1')) ||
         Rex::Version.new(test_version).between?(Rex::Version.new('2.38'), Rex::Version.new('2.38.6'))
    Severity: Minor
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb and 1 other location - About 20 mins to fix
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 115..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          if Rex::Version.new(test_version).between?(Rex::Version.new('2.31'), Rex::Version.new('2.31.13.11.7')) ||
         Rex::Version.new(test_version).between?(Rex::Version.new('2.36'), Rex::Version.new('2.36.9.12.3'))
        return CheckCode::Appears("The glibc version (#{glibc_version}) found on the target appears to be vulnerable")
    Severity: Minor
    Found in modules/exploits/linux/local/glibc_tunables_priv_esc.rb and 1 other location - About 20 mins to fix
    modules/exploits/linux/local/glibc_tunables_priv_esc.rb on lines 108..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status