Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/libuser_roothelper_priv_esc.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Libuser roothelper Privilege Escalation',
Severity: Major
Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 2 hrs to fix

    Method on_new_session has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def on_new_session(session)
    new_user_removed = false

    if session.type.to_s.eql? 'meterpreter'
      session.core.use 'stdapi' unless session.ext.aliases.include? 'stdapi'
    Severity: Minor
    Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
    Severity: Major
    Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 2 hrs to fix

      Method exploit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
      Severity: Minor
      Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    userhelper_path = '/usr/sbin/userhelper'
    return CheckCode::Safe("#{userhelper_path} file not found") unless file? userhelper_path
    return CheckCode::Safe("#{userhelper_path} is not setuid") unless setuid? userhelper_path
      Severity: Minor
      Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    userhelper_path = '/usr/sbin/userhelper'
    return CheckCode::Safe("#{userhelper_path} file not found") unless file? userhelper_path
    return CheckCode::Safe("#{userhelper_path} is not setuid") unless setuid? userhelper_path
        Severity: Minor
        Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return CheckCode::Safe
        Severity: Major
        Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Detected
          Severity: Major
          Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 30 mins to fix

            Method live_compile? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def live_compile?
    compile = false

    if datastore['COMPILE'].eql?('Auto') || datastore['COMPILE'].eql?('True')
      if has_gcc?
            Severity: Minor
            Found in modules/exploits/linux/local/libuser_roothelper_priv_esc.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status