Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/overlayfs_priv_esc.rb

Summary

Maintainability
D
3 days
Test Coverage

Method exploit has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit

    if check != CheckCode::Appears
      fail_with(Failure::NotVulnerable, 'Target not vulnerable! punt!')
    end
Severity: Major
Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 4 hrs to fix

    Method check has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    def mounts_exist?()
      vprint_status('Checking if mount points exist')
      if target.name == 'CVE-2015-1328'
        if not directory?('/tmp/ns_sploit')
    Severity: Major
    Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 3 hrs to fix

      Method kernel_vuln? has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          def kernel_vuln?()
      os_id = cmd_exec('grep ^ID= /etc/os-release')
      case os_id
      when 'ID=ubuntu'
        kernel = Rex::Version.new(cmd_exec('/bin/uname -r'))
      Severity: Minor
      Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit

    if check != CheckCode::Appears
      fail_with(Failure::NotVulnerable, 'Target not vulnerable! punt!')
    end
      Severity: Minor
      Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File overlayfs_priv_esc.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class MetasploitModule < Msf::Exploit::Local
  Rank = GoodRanking

  include Msf::Post::File
  include Msf::Exploit::EXE
      Severity: Minor
      Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 2 hrs to fix

        Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
    super(update_info(info,
        'Name'           => 'Overlayfs Privilege Escalation',
        'Description'    => %q{
          This module attempts to exploit two different CVEs related to overlayfs.
        Severity: Minor
        Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 2 hrs to fix

          Method mounts_exist? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def mounts_exist?()
      vprint_status('Checking if mount points exist')
      if target.name == 'CVE-2015-1328'
        if not directory?('/tmp/ns_sploit')
          vprint_good('/tmp/ns_sploit not created')
          Severity: Minor
          Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return false
          Severity: Major
          Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return false
            Severity: Major
            Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return true
              Severity: Major
              Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return false
                Severity: Major
                Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                            return true
                  Severity: Major
                  Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return true
                    Severity: Major
                    Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return false
                      Severity: Major
                      Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return true
                        Severity: Major
                        Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return false
                          Severity: Major
                          Found in modules/exploits/linux/local/overlayfs_priv_esc.rb - About 30 mins to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    when '3.16.0'
          if kernel.between?(Rex::Version.new('3.16.0-25-generic'),Rex::Version.new('3.16.0-40-generic'))
            vprint_good("Kernel #{kernel} is vulnerable to CVE-2015-1328")
            return true
          else
                            Severity: Minor
                            Found in modules/exploits/linux/local/overlayfs_priv_esc.rb and 2 other locations - About 25 mins to fix
                            modules/exploits/linux/local/overlayfs_priv_esc.rb on lines 94..100
                            modules/exploits/linux/local/overlayfs_priv_esc.rb on lines 121..127

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 30.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    when '3.13.0'
          if kernel.between?(Rex::Version.new('3.13.0-24-generic'),Rex::Version.new('3.13.0-54-generic'))
            vprint_good("Kernel #{kernel} is vulnerable to CVE-2015-1328")
            return true
          else
                            Severity: Minor
                            Found in modules/exploits/linux/local/overlayfs_priv_esc.rb and 2 other locations - About 25 mins to fix
                            modules/exploits/linux/local/overlayfs_priv_esc.rb on lines 102..108
                            modules/exploits/linux/local/overlayfs_priv_esc.rb on lines 121..127

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 30.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    when '4.2.0'
          if kernel.between?(Rex::Version.new('4.2.0-18-generic'),Rex::Version.new('4.2.0-22-generic'))
            vprint_good("Kernel #{kernel} is vulnerable to CVE-2015-8660")
            return true
          else
                            Severity: Minor
                            Found in modules/exploits/linux/local/overlayfs_priv_esc.rb and 2 other locations - About 25 mins to fix
                            modules/exploits/linux/local/overlayfs_priv_esc.rb on lines 94..100
                            modules/exploits/linux/local/overlayfs_priv_esc.rb on lines 102..108

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 30.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status