Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Reliable Datagram Sockets (RDS) rds_atomic_free_op NULL pointer dereference Privilege Escalation',
      'Description'    => %q{
        This module attempts to gain root privileges on Linux systems by abusing
Severity: Major
Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb - About 2 hrs to fix

    Method check has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    arch = kernel_hardware
    unless arch.include? 'x86_64'
      return CheckCode::Safe("System architecture #{arch} is not supported")
    end
    Severity: Minor
    Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    arch = kernel_hardware
    unless arch.include? 'x86_64'
      return CheckCode::Safe("System architecture #{arch} is not supported")
    end
      Severity: Minor
      Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return CheckCode::Safe('grsecurity is in use')
      Severity: Major
      Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return CheckCode::Detected('rds.ko kernel module is not loaded, but may be autoloaded during exploitation')
        Severity: Major
        Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb - About 30 mins to fix

          Method exploit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
          Severity: Minor
          Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 17 locations. Consider refactoring.
          Open

                    [ 'CVE', '2018-5333' ],
          [ 'CVE', '2019-9213' ],
          [ 'BID', '102510' ],
          [ 'URL', 'https://gist.github.com/wbowling/9d32492bd96d9e7c3bf52e23a0ac30a4' ],
          [ 'URL', 'https://github.com/0x36/CVE-pocs/blob/master/CVE-2018-5333-rds-nullderef.c' ],
          Severity: Major
          Found in modules/exploits/linux/local/rds_atomic_free_op_null_pointer_deref_priv_esc.rb and 16 other locations - About 25 mins to fix
          modules/auxiliary/scanner/smb/smb_ms17_010.rb on lines 37..46
          modules/exploits/freebsd/local/intel_sysret_priv_esc.rb on lines 52..61
          modules/exploits/linux/local/af_packet_chocobo_root_priv_esc.rb on lines 59..68
          modules/exploits/linux/local/docker_cgroup_escape.rb on lines 49..58
          modules/exploits/linux/local/network_manager_vpnc_username_priv_esc.rb on lines 45..54
          modules/exploits/linux/local/ufo_privilege_escalation.rb on lines 57..66
          modules/exploits/multi/fileformat/evince_cbt_cmd_injection.rb on lines 42..51
          modules/exploits/multi/http/joomla_http_header_rce.rb on lines 31..40
          modules/exploits/multi/script/web_delivery.rb on lines 79..88
          modules/exploits/solaris/local/libnspr_nspr_log_file_priv_esc.rb on lines 39..48
          modules/exploits/solaris/local/rsh_stack_clash_priv_esc.rb on lines 45..54
          modules/exploits/unix/smtp/exim4_string_format.rb on lines 49..58
          modules/exploits/unix/webapp/open_flash_chart_upload_exec.rb on lines 30..39
          modules/exploits/windows/http/exchange_proxylogon_rce.rb on lines 46..58
          modules/exploits/windows/local/ms_ndproxy.rb on lines 70..79
          modules/exploits/windows/scada/rockwell_factorytalk_rce.rb on lines 32..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status