Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/sock_sendpage.rb

Summary

Maintainability
D
2 days
Test Coverage

Method exploit has 272 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
Severity: Major
Found in modules/exploits/linux/local/sock_sendpage.rb - About 1 day to fix

    File sock_sendpage.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Local
  Rank = GreatRanking

  include Msf::Post::File
  include Msf::Post::Linux::Priv
    Severity: Minor
    Found in modules/exploits/linux/local/sock_sendpage.rb - About 5 hrs to fix

      Method initialize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Linux Kernel Sendpage Local Privilege Escalation',
      'Description'    => %q{
        The Linux kernel failed to properly initialize some entries in the
      Severity: Major
      Found in modules/exploits/linux/local/sock_sendpage.rb - About 2 hrs to fix

        Method check has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check
    version = Rex::Version.new kernel_release.split('-').first

    if version.to_s.eql? ''
      vprint_error 'Could not determine the kernel version'
        Severity: Minor
        Found in modules/exploits/linux/local/sock_sendpage.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    version = Rex::Version.new kernel_release.split('-').first

    if version.to_s.eql? ''
      vprint_error 'Could not determine the kernel version'
          Severity: Minor
          Found in modules/exploits/linux/local/sock_sendpage.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method exploit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
          Severity: Minor
          Found in modules/exploits/linux/local/sock_sendpage.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                return CheckCode::Safe
          Severity: Major
          Found in modules/exploits/linux/local/sock_sendpage.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status