Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/tomcat_ubuntu_log_init_priv_esc.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method exploit has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # Check if we're already root
    if is_root? && !datastore['ForceExploit']
      fail_with Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override'
    end
Severity: Major
Found in modules/exploits/linux/local/tomcat_ubuntu_log_init_priv_esc.rb - About 2 hrs to fix

    Method initialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Apache Tomcat on Ubuntu Log Init Privilege Escalation',
    Severity: Minor
    Found in modules/exploits/linux/local/tomcat_ubuntu_log_init_priv_esc.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    # Check if we're already root
    if is_root? && !datastore['ForceExploit']
      fail_with Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override'
    end
      Severity: Minor
      Found in modules/exploits/linux/local/tomcat_ubuntu_log_init_priv_esc.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    package = cmd_exec('dpkg -l tomcat[6-8] | grep \'^i\'')
    if package.nil? || package.empty?
      return CheckCode::Safe('Unable to execute command to determine installed pacakges')
    end
      Severity: Minor
      Found in modules/exploits/linux/local/tomcat_ubuntu_log_init_priv_esc.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

          if (package.to_s.start_with?('8') && package < Rex::Version.new('8.0.32-1ubuntu1.2')) ||
       (package.to_s.start_with?('7') && package < Rex::Version.new('7.0.52-1ubuntu0.7')) ||
       (package.to_s.start_with?('6') && package < Rex::Version.new('6.0.35-1ubuntu3.8'))
      return CheckCode::Appears("Vulnerable app version detected: #{package}")
    end
      Severity: Major
      Found in modules/exploits/linux/local/tomcat_ubuntu_log_init_priv_esc.rb - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status