Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/local/udev_netlink.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    if datastore["NetlinkPID"] and datastore["NetlinkPID"] != 0
      netlink_pid = datastore["NetlinkPID"]
    else
      print_status("Attempting to autodetect netlink pid...")
Severity: Major
Found in modules/exploits/linux/local/udev_netlink.rb - About 4 hrs to fix

    Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        {
    Severity: Minor
    Found in modules/exploits/linux/local/udev_netlink.rb - About 1 hr to fix

      Method autodetect_netlink_pid has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def autodetect_netlink_pid
    netlink_pid = nil

    case session.type
    when "meterpreter"
      Severity: Minor
      Found in modules/exploits/linux/local/udev_netlink.rb - About 1 hr to fix

        Method autodetect_netlink_pid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def autodetect_netlink_pid
    netlink_pid = nil

    case session.type
    when "meterpreter"
        Severity: Minor
        Found in modules/exploits/linux/local/udev_netlink.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method exploit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    if datastore["NetlinkPID"] and datastore["NetlinkPID"] != 0
      netlink_pid = datastore["NetlinkPID"]
    else
      print_status("Attempting to autodetect netlink pid...")
        Severity: Minor
        Found in modules/exploits/linux/local/udev_netlink.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status