Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/redis/redis_debian_sandbox_escape.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Redis Lua Sandbox Escape',
Severity: Major
Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb - About 3 hrs to fix

    Method check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    connect

    # Before we get crazy sending exploits over the wire, let's just check if this could
    # plausiably be a vulnerable version. Using INFO we can check for:
    Severity: Minor
    Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return Exploit::CheckCode::Vulnerable("Successfully executed the 'id' command.") unless result.nil? || result[/uid=.+ gid=.+ groups=.+/].nil?
    Severity: Major
    Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return Exploit::CheckCode::Safe("The reported version is unaffected: #{redis_version}") if Rex::Version.new(redis_version) >= Rex::Version.new('6.1.0')
      Severity: Major
      Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return Exploit::CheckCode::Unknown('Unsupported architecture') unless info_output.include? 'x86_64'
        Severity: Major
        Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return Exploit::CheckCode::Safe("The reported version is unaffected: #{redis_version}") if Rex::Version.new(redis_version) < Rex::Version.new('5.0.0')
          Severity: Major
          Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb - About 30 mins to fix

            Identical blocks of code found in 13 locations. Consider refactoring.
            Open

              def exploit
    print_status("Executing #{target.name} for #{datastore['PAYLOAD']}")
    case target['Type']
    when :unix_cmd
      execute_command(payload.encoded)
            Severity: Major
            Found in modules/exploits/linux/redis/redis_debian_sandbox_escape.rb and 12 other locations - About 15 mins to fix
            modules/exploits/linux/http/apache_ofbiz_deserialization_soap.rb on lines 109..116
            modules/exploits/linux/http/cisco_asax_sfr_rce.rb on lines 152..159
            modules/exploits/linux/http/f5_icontrol_rce.rb on lines 126..133
            modules/exploits/linux/http/glpi_htmlawed_php_injection.rb on lines 126..132
            modules/exploits/linux/http/grandstream_ucm62xx_sendemail_rce.rb on lines 174..180
            modules/exploits/linux/http/ivanti_sentry_misc_log_service.rb on lines 125..131
            modules/exploits/linux/http/mobileiron_mdm_hessian_rce.rb on lines 99..106
            modules/exploits/linux/http/spring_cloud_gateway_rce.rb on lines 156..162
            modules/exploits/linux/http/zyxel_ztp_rce.rb on lines 148..154
            modules/exploits/linux/local/zyxel_suid_cp_lpe.rb on lines 155..161
            modules/exploits/multi/http/cve_2021_35464_forgerock_openam.rb on lines 112..118
            modules/exploits/multi/http/spring_cloud_function_spel_injection.rb on lines 93..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status