Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/redis/redis_replication_cmd_exec.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Redis Replication Code Execution',
      'Description'    => %q{
        This module can be used to leverage the extension functionality added since Redis 4.0.0
Severity: Minor
Found in modules/exploits/linux/redis/redis_replication_cmd_exec.rb - About 2 hrs to fix

    Method start_rogue_server has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def start_rogue_server
    begin
      socket = Rex::Socket::TcpServer.create({'LocalHost'=>srvhost,'LocalPort'=>srvport})
      print_status("Listening on #{srvhost}:#{srvport}")
    rescue Rex::BindFailed
    Severity: Minor
    Found in modules/exploits/linux/redis/redis_replication_cmd_exec.rb - About 1 hr to fix

      Method start_rogue_server has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def start_rogue_server
    begin
      socket = Rex::Socket::TcpServer.create({'LocalHost'=>srvhost,'LocalPort'=>srvport})
      print_status("Listening on #{srvhost}:#{srvport}")
    rescue Rex::BindFailed
      Severity: Minor
      Found in modules/exploits/linux/redis/redis_replication_cmd_exec.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exploit
    if check_custom
      @module_init_name = datastore['RedisModuleInit']    || Rex::Text.rand_text_alpha_lower(4..8)
      @module_cmd       = datastore['RedisModuleTrigger'] || "#{@module_init_name}.#{Rex::Text.rand_text_alpha_lower(4..8)}"
    else
      Severity: Minor
      Found in modules/exploits/linux/redis/redis_replication_cmd_exec.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    connect
    # they are only vulnerable if we can run the CONFIG command, so try that
    return Exploit::CheckCode::Safe unless (config_data = redis_command('CONFIG', 'GET', '*')) && config_data =~ /dbfilename/
        Severity: Minor
        Found in modules/exploits/linux/redis/redis_replication_cmd_exec.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_env has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def check_env
    # check if linux
    return false unless %x|uname -s 2>/dev/null|.include? "Linux"
    # check if gcc installed
    return false unless %x|command -v gcc && echo true|.include? "true"
        Severity: Minor
        Found in modules/exploits/linux/redis/redis_replication_cmd_exec.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status