Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/smtp/exim4_dovecot_exec.rb

Summary

Maintainability
D
1 day
Test Coverage

Method exploit has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit

    @pl = generate_payload_exe
    @elf_sent = false
Severity: Minor
Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit

    @pl = generate_payload_exe
    @elf_sent = false
Severity: Major
Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb - About 3 hrs to fix

    Method initialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Exim and Dovecot Insecure Configuration Command Injection',
      'Description'    => %q{
        This module exploits a command injection vulnerability against Dovecot with
    Severity: Minor
    Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            register_options(
      [
        OptString.new('EHLO', [ true, 'TO address of the e-mail', 'debian.localdomain']),
        OptString.new('MAILTO', [ true, 'TO address of the e-mail', 'root@debian.localdomain']),
        OptAddress.new('DOWNHOST', [ false, 'An alternative host to request the MIPS payload from' ]),
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 1 other location - About 50 mins to fix
      modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 64..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

        def wait_linux_payload
    print_status("#{rhost}:#{rport} - Waiting for the victim to request the ELF payload...")

    waited = 0
    while (not @elf_sent)
      Severity: Major
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 7 other locations - About 45 mins to fix
      modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 206..214
      modules/exploits/linux/http/dlink_dir615_up_exec.rb on lines 241..249
      modules/exploits/linux/http/linksys_e1500_apply_exec.rb on lines 234..242
      modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb on lines 401..409
      modules/exploits/linux/http/netgear_dgn1000b_setup_exec.rb on lines 238..246
      modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 343..351
      modules/exploits/multi/sap/sap_mgmt_con_osexec_payload.rb on lines 306..314

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          if not resp or resp[0,3] != '250'
      fail_with(Failure::Unknown, "#{rhost}:#{rport} - #{msg}")
    else
      print_status("#{rhost}:#{rport} - #{msg}")
    end
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 3 other locations - About 30 mins to fix
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 175..179
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 184..188
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 196..200

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          if not resp or resp[0,3] != '250'
      fail_with(Failure::Unknown, "#{rhost}:#{rport} - #{msg}")
    else
      print_status("#{rhost}:#{rport} - #{msg}")
    end
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 3 other locations - About 30 mins to fix
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 166..170
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 184..188
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 196..200

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          if not resp or resp[0,3] != '250'
      fail_with(Failure::Unknown, "#{rhost}:#{rport} - #{msg}")
    else
      print_status("#{rhost}:#{rport} - #{msg}")
    end
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 3 other locations - About 30 mins to fix
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 166..170
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 175..179
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 184..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          if not resp or resp[0,3] != '354'
      fail_with(Failure::Unknown, "#{rhost}:#{rport} - #{msg}")
    else
      print_status("#{rhost}:#{rport} - #{msg}")
    end
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 3 other locations - About 30 mins to fix
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 166..170
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 175..179
      modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 196..200

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 11 locations. Consider refactoring.
      Open

        def on_request_uri(cli, request)
    if (not @pl)
      print_error("#{rhost}:#{rport} - A request came in, but the payload wasn't ready yet!")
      return
    end
      Severity: Major
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 10 other locations - About 20 mins to fix
      modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 194..202
      modules/exploits/linux/http/dlink_dir615_up_exec.rb on lines 229..237
      modules/exploits/linux/http/linksys_e1500_apply_exec.rb on lines 222..230
      modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb on lines 389..397
      modules/exploits/linux/http/netgear_dgn1000b_setup_exec.rb on lines 226..234
      modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 331..339
      modules/exploits/multi/http/bassmaster_js_injection.rb on lines 87..94
      modules/exploits/multi/http/rails_dynamic_render_code_exec.rb on lines 95..102
      modules/exploits/multi/http/trendmicro_threat_discovery_admin_sys_time_cmdi.rb on lines 137..144
      modules/exploits/multi/sap/sap_mgmt_con_osexec_payload.rb on lines 294..302

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          if (datastore['DOWNHOST'])
      print_status("#{rhost}:#{rport} - Giving #{datastore['HTTP_DELAY']} seconds to the target to download the payload")
      select(nil, nil, nil, datastore['HTTP_DELAY'])
    else
      wait_linux_payload
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 5 other locations - About 15 mins to fix
      modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 163..167
      modules/exploits/linux/http/dlink_dir615_up_exec.rb on lines 193..197
      modules/exploits/linux/http/linksys_wrt160nv2_apply_exec.rb on lines 169..173
      modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 311..315
      modules/exploits/multi/sap/sap_mgmt_con_osexec_payload.rb on lines 259..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

            if (datastore['SRVHOST'] == "0.0.0.0" or datastore['SRVHOST'] == "::")
        srv_host = datastore['URIHOST'] || Rex::Socket.source_address(rhost)
      else
        srv_host = datastore['SRVHOST']
      end
      Severity: Minor
      Found in modules/exploits/linux/smtp/exim4_dovecot_exec.rb and 3 other locations - About 15 mins to fix
      modules/exploits/multi/http/bassmaster_js_injection.rb on lines 138..142
      modules/exploits/multi/http/rails_dynamic_render_code_exec.rb on lines 159..163
      modules/exploits/multi/http/trendmicro_threat_discovery_admin_sys_time_cmdi.rb on lines 154..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status